Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport the noti package to 18.09 #47396

Merged
merged 3 commits into from Sep 26, 2018
Merged

Backport the noti package to 18.09 #47396

merged 3 commits into from Sep 26, 2018

Conversation

rycee
Copy link
Member

@rycee rycee commented Sep 26, 2018 •
edited

This cherry-picks the package noti from master to 18.09. I'm doing this because Home Manager is having a noti module in its master branch and I would like to keep the HM master branch compatible with Nixpkgs 18.09 as long as possible to reduce the amount of maintenance I have to do.

xeji
xeji reviewed Sep 26, 2018
View reviewed changes
pkgs/tools/misc/noti/default.nix
'';
homepage = https://github.com/variadico/noti;
license = licenses.mit;
maintainers = [ maintainers.stites ];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maintainer doesn't exist on 18.09 -> eval error

stites and others added 3 commits September 26, 2018 18:54
@rycee
add stites to maintainers list
e861f31 
(cherry picked from commit 82f9808)
@rycee
noti: init at 3.1.0
e835796 
(cherry picked from commit f1c30cf)
@marsam @rycee
noti: fix darwin build
583a321 
(cherry picked from commit 4c56eb8)
@rycee
Copy link
Member Author

rycee commented Sep 26, 2018

Cherry-picked maintainer list update commit as well.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: noti

Partial log (click to expand)

Removing empty /nix/store/h2s7a576a810fa3cycjnnmw8wdn24s1f-noti-3.1.0/share/ and (possibly) its parents
shrinking RPATHs of ELF executables and libraries in /nix/store/vkcx5vs2jdm95isf1ajhayps17z21zwk-noti-3.1.0-bin
shrinking /nix/store/vkcx5vs2jdm95isf1ajhayps17z21zwk-noti-3.1.0-bin/bin/noti
gzipping man pages under /nix/store/vkcx5vs2jdm95isf1ajhayps17z21zwk-noti-3.1.0-bin/share/man/
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/vkcx5vs2jdm95isf1ajhayps17z21zwk-noti-3.1.0-bin/bin
patching script interpreter paths in /nix/store/vkcx5vs2jdm95isf1ajhayps17z21zwk-noti-3.1.0-bin
checking for references to /build in /nix/store/vkcx5vs2jdm95isf1ajhayps17z21zwk-noti-3.1.0-bin...
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
/nix/store/vkcx5vs2jdm95isf1ajhayps17z21zwk-noti-3.1.0-bin

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: noti

Partial log (click to expand)

Removing empty /nix/store/dhyfc0lh6m22kh0365cn5347nw1i18vh-noti-3.1.0/share/ and (possibly) its parents
shrinking RPATHs of ELF executables and libraries in /nix/store/z146n7w3jln39avif4lvs3qs2v9r7hdh-noti-3.1.0-bin
shrinking /nix/store/z146n7w3jln39avif4lvs3qs2v9r7hdh-noti-3.1.0-bin/bin/noti
gzipping man pages under /nix/store/z146n7w3jln39avif4lvs3qs2v9r7hdh-noti-3.1.0-bin/share/man/
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/z146n7w3jln39avif4lvs3qs2v9r7hdh-noti-3.1.0-bin/bin
patching script interpreter paths in /nix/store/z146n7w3jln39avif4lvs3qs2v9r7hdh-noti-3.1.0-bin
checking for references to /build in /nix/store/z146n7w3jln39avif4lvs3qs2v9r7hdh-noti-3.1.0-bin...
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
/nix/store/z146n7w3jln39avif4lvs3qs2v9r7hdh-noti-3.1.0-bin

@xeji
Copy link
Contributor

xeji commented Sep 26, 2018

check darwin build
@GrahamcOfBorg build noti

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: noti

Partial log (click to expand)

/nix/store/vkcx5vs2jdm95isf1ajhayps17z21zwk-noti-3.1.0-bin

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: noti

Partial log (click to expand)

Removing empty /nix/store/dhyfc0lh6m22kh0365cn5347nw1i18vh-noti-3.1.0/share/ and (possibly) its parents
shrinking RPATHs of ELF executables and libraries in /nix/store/z146n7w3jln39avif4lvs3qs2v9r7hdh-noti-3.1.0-bin
shrinking /nix/store/z146n7w3jln39avif4lvs3qs2v9r7hdh-noti-3.1.0-bin/bin/noti
gzipping man pages under /nix/store/z146n7w3jln39avif4lvs3qs2v9r7hdh-noti-3.1.0-bin/share/man/
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/z146n7w3jln39avif4lvs3qs2v9r7hdh-noti-3.1.0-bin/bin
patching script interpreter paths in /nix/store/z146n7w3jln39avif4lvs3qs2v9r7hdh-noti-3.1.0-bin
checking for references to /build in /nix/store/z146n7w3jln39avif4lvs3qs2v9r7hdh-noti-3.1.0-bin...
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
/nix/store/z146n7w3jln39avif4lvs3qs2v9r7hdh-noti-3.1.0-bin

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: noti

Partial log (click to expand)

find: '/nix/store/kwrwkydr3b38g2xhx360nhh1pdb2blid-noti-3.1.0': No such file or directory
find: '/nix/store/kwrwkydr3b38g2xhx360nhh1pdb2blid-noti-3.1.0': No such file or directory
find: '/nix/store/kwrwkydr3b38g2xhx360nhh1pdb2blid-noti-3.1.0': No such file or directory
find: '/nix/store/kwrwkydr3b38g2xhx360nhh1pdb2blid-noti-3.1.0': No such file or directory
find: '/nix/store/kwrwkydr3b38g2xhx360nhh1pdb2blid-noti-3.1.0': No such file or directory
find: '/nix/store/kwrwkydr3b38g2xhx360nhh1pdb2blid-noti-3.1.0': No such file or directory
find: '/nix/store/kwrwkydr3b38g2xhx360nhh1pdb2blid-noti-3.1.0': No such file or directory
find: '/nix/store/kwrwkydr3b38g2xhx360nhh1pdb2blid-noti-3.1.0': No such file or directory
find: '/nix/store/kwrwkydr3b38g2xhx360nhh1pdb2blid-noti-3.1.0': No such file or directory
/nix/store/7f8w5a715cpax4rm4xlyhv0lf7mns4zm-noti-3.1.0-bin

@xeji xeji merged commit e5eabcc into NixOS:release-18.09 Sep 26, 2018
@rycee
Copy link
Member Author

rycee commented Sep 26, 2018

Thanks @xeji! 👍

@rycee rycee deleted the backport/noti branch September 26, 2018 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xeji xeji xeji left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rycee @GrahamcOfBorg @xeji @marsam