Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ejson: init at 1.2.0 #47389

Merged
merged 1 commit into from Oct 11, 2018
Merged

ejson: init at 1.2.0 #47389

merged 1 commit into from Oct 11, 2018

Conversation

manveru
Copy link
Contributor

@manveru manveru commented Sep 26, 2018 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@joachifm
Copy link
Contributor

@GrahamcOfBorg build ejson

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: ejson

Partial log (click to expand)

shrinking /nix/store/k5cym539n3qwzb7dfzsnl4r01hxrhp7r-ejson-1.2.0-bin/bin/ejson
cannot find section .dynamic
gzipping man pages under /nix/store/k5cym539n3qwzb7dfzsnl4r01hxrhp7r-ejson-1.2.0-bin/share/man/
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/k5cym539n3qwzb7dfzsnl4r01hxrhp7r-ejson-1.2.0-bin/bin
patching script interpreter paths in /nix/store/k5cym539n3qwzb7dfzsnl4r01hxrhp7r-ejson-1.2.0-bin
checking for references to /build in /nix/store/k5cym539n3qwzb7dfzsnl4r01hxrhp7r-ejson-1.2.0-bin...
cannot find section .dynamic
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
/nix/store/k5cym539n3qwzb7dfzsnl4r01hxrhp7r-ejson-1.2.0-bin

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: ejson

Partial log (click to expand)

find: '/nix/store/ss1896k1gmjrj9py3vdqzzlby0c10m3v-ejson-1.2.0': No such file or directory
find: '/nix/store/ss1896k1gmjrj9py3vdqzzlby0c10m3v-ejson-1.2.0': No such file or directory
find: '/nix/store/ss1896k1gmjrj9py3vdqzzlby0c10m3v-ejson-1.2.0': No such file or directory
find: '/nix/store/ss1896k1gmjrj9py3vdqzzlby0c10m3v-ejson-1.2.0': No such file or directory
find: '/nix/store/ss1896k1gmjrj9py3vdqzzlby0c10m3v-ejson-1.2.0': No such file or directory
find: '/nix/store/ss1896k1gmjrj9py3vdqzzlby0c10m3v-ejson-1.2.0': No such file or directory
find: '/nix/store/ss1896k1gmjrj9py3vdqzzlby0c10m3v-ejson-1.2.0': No such file or directory
find: '/nix/store/ss1896k1gmjrj9py3vdqzzlby0c10m3v-ejson-1.2.0': No such file or directory
find: '/nix/store/ss1896k1gmjrj9py3vdqzzlby0c10m3v-ejson-1.2.0': No such file or directory
/nix/store/cq3j17gg4v8y6k58cc3a51gijhxxlhfj-ejson-1.2.0-bin

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: ejson

Partial log (click to expand)

shrinking /nix/store/dg44i5bgrqxjyfbg6xn7mkq7s912i7lk-ejson-1.2.0-bin/bin/ejson
cannot find section .dynamic
gzipping man pages under /nix/store/dg44i5bgrqxjyfbg6xn7mkq7s912i7lk-ejson-1.2.0-bin/share/man/
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/dg44i5bgrqxjyfbg6xn7mkq7s912i7lk-ejson-1.2.0-bin/bin
patching script interpreter paths in /nix/store/dg44i5bgrqxjyfbg6xn7mkq7s912i7lk-ejson-1.2.0-bin
checking for references to /build in /nix/store/dg44i5bgrqxjyfbg6xn7mkq7s912i7lk-ejson-1.2.0-bin...
cannot find section .dynamic
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
/nix/store/dg44i5bgrqxjyfbg6xn7mkq7s912i7lk-ejson-1.2.0-bin

matthewbauer
matthewbauer approved these changes Sep 29, 2018
View reviewed changes
Copy link
Member

@matthewbauer matthewbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. As an aside, I hate how many files and extra lines we need to add for packages like this. It would be nice if they could share dependencies like we do with haskell and node.

@infinisil infinisil merged commit 177ddb9 into NixOS:master Oct 11, 2018
@manveru manveru deleted the add-ejson branch December 12, 2019 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewbauer matthewbauer matthewbauer approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@manveru @joachifm @GrahamcOfBorg @matthewbauer @infinisil