Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vscode: 1.26.1 -> 1.27.2 #47397

Merged
merged 1 commit into from Sep 27, 2018
Merged

vscode: 1.26.1 -> 1.27.2 #47397

merged 1 commit into from Sep 27, 2018

Conversation

bkchr
Copy link
Contributor

@bkchr bkchr commented Sep 26, 2018 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@xeji
Copy link
Contributor

xeji commented Sep 27, 2018

unfree package, build checked on x86_64-linux

@xeji xeji merged commit 0d810c5 into NixOS:master Sep 27, 2018
Mic92 pushed a commit that referenced this pull request Oct 19, 2018
@bkchr @Mic92
vscode: 1.26.1 -> 1.27.2 (#47397)
d8649a8 
(cherry picked from commit 0d810c5)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bkchr @xeji @GrahamcOfBorg