Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vimPlugins.ncm2: init at 2018-09-03 #46566

Merged
merged 2 commits into from Sep 13, 2018
Merged

vimPlugins.ncm2: init at 2018-09-03 #46566

merged 2 commits into from Sep 13, 2018

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Sep 12, 2018

Motivation for this change

This is the new version of nvim-completion-manager. Should we remove the old plugin?

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@Mic92 Mic92 changed the title vimPlugins.Ncm2: init at 2018-09-03 vimPlugins.ncm2: init at 2018-09-03 Sep 12, 2018
@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: vimPlugins.LanguageClient-neovim, vimPlugins.ncm2

Partial log (click to expand)

installing
post-installation fixup
strip is /nix/store/df6k4mgdjxciy0f637lryp7c9ln7n1m3-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/68ah5y8p8wg6pfx5i08fbgr883v27fn9-vimplugin-LanguageClient-neovim-2018-09-07
/nix/store/68ah5y8p8wg6pfx5i08fbgr883v27fn9-vimplugin-LanguageClient-neovim-2018-09-07/share/vim-plugins/LanguageClient-neovim/ci/script.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/cblfnvb5rmhd2z231mqasn0brzh1hhv4-bash-4.4-p23/bin/bash"
/nix/store/68ah5y8p8wg6pfx5i08fbgr883v27fn9-vimplugin-LanguageClient-neovim-2018-09-07/share/vim-plugins/LanguageClient-neovim/install.sh: interpreter directive changed from "/usr/bin/env sh" to "/nix/store/cblfnvb5rmhd2z231mqasn0brzh1hhv4-bash-4.4-p23/bin/sh"
/nix/store/68ah5y8p8wg6pfx5i08fbgr883v27fn9-vimplugin-LanguageClient-neovim-2018-09-07/share/vim-plugins/LanguageClient-neovim/tests/wrapper-server.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/cblfnvb5rmhd2z231mqasn0brzh1hhv4-bash-4.4-p23/bin/bash"
/nix/store/68ah5y8p8wg6pfx5i08fbgr883v27fn9-vimplugin-LanguageClient-neovim-2018-09-07/share/vim-plugins/LanguageClient-neovim/tests/test.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/cblfnvb5rmhd2z231mqasn0brzh1hhv4-bash-4.4-p23/bin/bash"
/nix/store/68ah5y8p8wg6pfx5i08fbgr883v27fn9-vimplugin-LanguageClient-neovim-2018-09-07
/nix/store/a4706lq15sm2rn3jrl1xw6k3vcwvk1v2-vimplugin-ncm2-2018-09-03

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: vimPlugins.LanguageClient-neovim, vimPlugins.ncm2

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/znkcbfizdy5a9i112sl34cb268sp72fy-vimplugin-LanguageClient-neovim-2018-09-07
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/znkcbfizdy5a9i112sl34cb268sp72fy-vimplugin-LanguageClient-neovim-2018-09-07
/nix/store/znkcbfizdy5a9i112sl34cb268sp72fy-vimplugin-LanguageClient-neovim-2018-09-07/share/vim-plugins/LanguageClient-neovim/tests/wrapper-server.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/fqm2x6kiay1q4vg7pqp4wp17bdijlyc3-bash-4.4-p23/bin/bash"
/nix/store/znkcbfizdy5a9i112sl34cb268sp72fy-vimplugin-LanguageClient-neovim-2018-09-07/share/vim-plugins/LanguageClient-neovim/tests/test.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/fqm2x6kiay1q4vg7pqp4wp17bdijlyc3-bash-4.4-p23/bin/bash"
/nix/store/znkcbfizdy5a9i112sl34cb268sp72fy-vimplugin-LanguageClient-neovim-2018-09-07/share/vim-plugins/LanguageClient-neovim/install.sh: interpreter directive changed from "/usr/bin/env sh" to "/nix/store/fqm2x6kiay1q4vg7pqp4wp17bdijlyc3-bash-4.4-p23/bin/sh"
/nix/store/znkcbfizdy5a9i112sl34cb268sp72fy-vimplugin-LanguageClient-neovim-2018-09-07/share/vim-plugins/LanguageClient-neovim/ci/script.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/fqm2x6kiay1q4vg7pqp4wp17bdijlyc3-bash-4.4-p23/bin/bash"
checking for references to /build in /nix/store/znkcbfizdy5a9i112sl34cb268sp72fy-vimplugin-LanguageClient-neovim-2018-09-07...
/nix/store/znkcbfizdy5a9i112sl34cb268sp72fy-vimplugin-LanguageClient-neovim-2018-09-07
/nix/store/isds8lps82p3w39vf0wrqngvhali78zl-vimplugin-ncm2-2018-09-03

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: vimPlugins.LanguageClient-neovim, vimPlugins.ncm2

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/injhhxa6pgfi4vp269rjbwqmjs58xp4z-vimplugin-LanguageClient-neovim-2018-09-07
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/injhhxa6pgfi4vp269rjbwqmjs58xp4z-vimplugin-LanguageClient-neovim-2018-09-07
/nix/store/injhhxa6pgfi4vp269rjbwqmjs58xp4z-vimplugin-LanguageClient-neovim-2018-09-07/share/vim-plugins/LanguageClient-neovim/ci/script.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/bash"
/nix/store/injhhxa6pgfi4vp269rjbwqmjs58xp4z-vimplugin-LanguageClient-neovim-2018-09-07/share/vim-plugins/LanguageClient-neovim/tests/test.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/bash"
/nix/store/injhhxa6pgfi4vp269rjbwqmjs58xp4z-vimplugin-LanguageClient-neovim-2018-09-07/share/vim-plugins/LanguageClient-neovim/tests/wrapper-server.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/bash"
/nix/store/injhhxa6pgfi4vp269rjbwqmjs58xp4z-vimplugin-LanguageClient-neovim-2018-09-07/share/vim-plugins/LanguageClient-neovim/install.sh: interpreter directive changed from "/usr/bin/env sh" to "/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/injhhxa6pgfi4vp269rjbwqmjs58xp4z-vimplugin-LanguageClient-neovim-2018-09-07...
/nix/store/injhhxa6pgfi4vp269rjbwqmjs58xp4z-vimplugin-LanguageClient-neovim-2018-09-07
/nix/store/pmb7pxyc1ggvpxcxxig4g7xjwva3ql78-vimplugin-ncm2-2018-09-03

@xeji
Copy link
Contributor

xeji commented Sep 13, 2018

Nice, I always wanted to try that.

Should we remove the old plugin?

Upstream repo https://github.com/roxma/nvim-completion-manager is archived and deprecated, but I guess it still works, and removing it may break existing configs. But then we need to remove it someday... Hope we get a standard deprecation mechanism soon.

@Mic92
Copy link
Member Author

Mic92 commented Sep 13, 2018

Something like deprecated; we will remove this in the next release would be nice.

@Mic92 Mic92 merged commit cfc8e26 into NixOS:master Sep 13, 2018
@Mic92
Copy link
Member Author

Mic92 commented Sep 13, 2018 •
edited

this is what they recommend as settings in the vimrc: Mic92/dotfiles@dc5e389

@Mic92 Mic92 deleted the ncm2 branch September 13, 2018 17:37
@xeji
Copy link
Contributor

xeji commented Sep 13, 2018

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: vim 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Mic92 @GrahamcOfBorg @xeji