Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

syncthing: 0.14.48 -> 0.14.50 #46565

Merged
merged 1 commit into from Sep 12, 2018
Merged

syncthing: 0.14.48 -> 0.14.50 #46565

merged 1 commit into from Sep 12, 2018

Conversation

jluttine
Copy link
Member

Motivation for this change

Upgrade syncthing.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member

Mic92 commented Sep 12, 2018

Should this be backported (is this a bug fix release?)

@Mic92
Copy link
Member

Mic92 commented Sep 12, 2018

@GrahamcOfBorg build syncthing

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: syncthing

Partial log (click to expand)

github.com/syncthing/syncthing/lib/connections
github.com/syncthing/syncthing/lib/model
github.com/syncthing/syncthing/cmd/syncthing
installing
post-installation fixup
gzipping man pages under /nix/store/w2hpyix17bppy51z0bxip8z3i3gyvlhc-syncthing-0.14.50/share/man/
strip is /nix/store/df6k4mgdjxciy0f637lryp7c9ln7n1m3-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/w2hpyix17bppy51z0bxip8z3i3gyvlhc-syncthing-0.14.50/bin
patching script interpreter paths in /nix/store/w2hpyix17bppy51z0bxip8z3i3gyvlhc-syncthing-0.14.50
/nix/store/w2hpyix17bppy51z0bxip8z3i3gyvlhc-syncthing-0.14.50

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: syncthing

Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/fs4g52nwr8sx9jar2bv3vml20mwirqn0-syncthing-0.14.50
shrinking /nix/store/fs4g52nwr8sx9jar2bv3vml20mwirqn0-syncthing-0.14.50/bin/syncthing
gzipping man pages under /nix/store/fs4g52nwr8sx9jar2bv3vml20mwirqn0-syncthing-0.14.50/share/man/
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/fs4g52nwr8sx9jar2bv3vml20mwirqn0-syncthing-0.14.50/lib  /nix/store/fs4g52nwr8sx9jar2bv3vml20mwirqn0-syncthing-0.14.50/bin
patching script interpreter paths in /nix/store/fs4g52nwr8sx9jar2bv3vml20mwirqn0-syncthing-0.14.50
checking for references to /build in /nix/store/fs4g52nwr8sx9jar2bv3vml20mwirqn0-syncthing-0.14.50...
/nix/store/fs4g52nwr8sx9jar2bv3vml20mwirqn0-syncthing-0.14.50

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: syncthing

Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/w515h961rn0fynrv2r4yi6q14nxyszha-syncthing-0.14.50
shrinking /nix/store/w515h961rn0fynrv2r4yi6q14nxyszha-syncthing-0.14.50/bin/syncthing
gzipping man pages under /nix/store/w515h961rn0fynrv2r4yi6q14nxyszha-syncthing-0.14.50/share/man/
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/w515h961rn0fynrv2r4yi6q14nxyszha-syncthing-0.14.50/lib  /nix/store/w515h961rn0fynrv2r4yi6q14nxyszha-syncthing-0.14.50/bin
patching script interpreter paths in /nix/store/w515h961rn0fynrv2r4yi6q14nxyszha-syncthing-0.14.50
checking for references to /build in /nix/store/w515h961rn0fynrv2r4yi6q14nxyszha-syncthing-0.14.50...
/nix/store/w515h961rn0fynrv2r4yi6q14nxyszha-syncthing-0.14.50

@Mic92
Copy link
Member

Mic92 commented Sep 12, 2018

Can you ask for ofborg access? NixOS/ofborg#222

@Mic92 Mic92 merged commit 7e2428d into NixOS:master Sep 12, 2018
@jluttine jluttine mentioned this pull request Sep 12, 2018
Merged
@jluttine
Copy link
Member Author

Asked for ofborg acces.

I think it'd be good to backport this. At least my syncthing was broken without this bugfix release.

@Mic92
Copy link
Member

Mic92 commented Sep 13, 2018

done 1851422

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jluttine @Mic92 @GrahamcOfBorg