Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python-language-server: 0.19.0 -> 0.21.2 #46563

Merged
merged 2 commits into from Sep 12, 2018
Merged

python-language-server: 0.19.0 -> 0.21.2 #46563

merged 2 commits into from Sep 12, 2018

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Sep 12, 2018 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@Mic92 Mic92 requested a review from FRidh as a code owner September 12, 2018 08:03
@Mic92
Copy link
Member Author

Mic92 commented Sep 12, 2018

@GrahamcOfBorg build python3Packages.python-language-server python2Packages.python-language-server

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python3Packages.python-language-server, python2Packages.python-language-server

Partial log (click to expand)

test/test_uris.py                          17      2    88%
test/test_utils.py                         56      0   100%
test/test_workspace.py                     33      0   100%
-----------------------------------------------------------
TOTAL                                    1688    209    88%
Coverage HTML written to dir htmlcov

===================== 67 passed, 5 skipped in 7.67 seconds =====================
/nix/store/as79pjwkwardw59xq23j0nsph51xhwwp-python3.6-python-language-server-0.21.2
/nix/store/19pjs01f2w56628j0wfdf7w658c3x2f8-python2.7-python-language-server-0.21.2

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: python3Packages.python-language-server, python2Packages.python-language-server

Partial log (click to expand)

test/test_uris.py                          17      2    88%
test/test_utils.py                         56      0   100%
test/test_workspace.py                     33      0   100%
-----------------------------------------------------------
TOTAL                                    1688    210    88%
Coverage HTML written to dir htmlcov

===================== 67 passed, 5 skipped in 7.65 seconds =====================
/nix/store/0pcpqpy373z66q6z20rqp5k9rydxzycw-python3.6-python-language-server-0.21.2
/nix/store/q9irv4fnqn3jczm6bjxbijrpm68vahrh-python2.7-python-language-server-0.21.2

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python3Packages.python-language-server, python2Packages.python-language-server

Partial log (click to expand)

test/test_utils.py                         56      0   100%
test/test_workspace.py                     33      0   100%
-----------------------------------------------------------
TOTAL                                    1688    209    88%
Coverage HTML written to dir htmlcov

==================== 67 passed, 5 skipped in 28.42 seconds =====================
2018-09-12 08:06:43,024 UTC - DEBUG - pyls.python_ls - parent process 1 is still alive
/nix/store/7yl0bi5nk9jqarr7hi7fp763g0k57q5i-python3.6-python-language-server-0.21.2
/nix/store/qyq3ylkypq0d7yd3ybrz84b1q3hcfv1j-python2.7-python-language-server-0.21.2

@Mic92 Mic92 merged commit 1696eb4 into NixOS:master Sep 12, 2018
@Mic92 Mic92 deleted the pyls branch September 12, 2018 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Mic92 @GrahamcOfBorg