Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.Nikola: 7.8.15 -> 8.0.1 #46564

Merged
merged 3 commits into from Oct 21, 2018
Merged

pythonPackages.Nikola: 7.8.15 -> 8.0.1 #46564

merged 3 commits into from Oct 21, 2018

Conversation

jluttine
Copy link
Member

Motivation for this change

Upgrade Nikola to 8.0.0 and also add/update some dependencies.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member

Mic92 commented Sep 12, 2018

@GrahamcOfBorg eval

@Mic92 Mic92 changed the title Nikola 8.0.0 pythonPackages.Nikola: 7.8.15 -> 8.0.0 Sep 12, 2018
@jluttine
Copy link
Member Author

jluttine commented Sep 12, 2018 •
edited

I made the requested fixes.

EDIT: Nox review passed.

@jluttine
Copy link
Member Author

jluttine commented Sep 13, 2018 •
edited

Should the names of Nikola and Logbook be normalized to nikola and logbook or at least made available also by the normalized names? Or do we only normalize names for new package definitions and keep the existing package names inconsistent?

@jluttine jluttine changed the title pythonPackages.Nikola: 7.8.15 -> 8.0.0 pythonPackages.Nikola: 7.8.15 -> 8.0.1 Oct 2, 2018
@jluttine
Copy link
Member Author

jluttine commented Oct 2, 2018

Nikola got updated so I updated this pull request so that Nikola is now updated to 8.0.1 instead of 8.0.0.

I'm just unsure should I normalize the package names of Nikola and Logbook as I've been instructed that the names should be normalized but on the other hand the names have these already.

@FRidh
Copy link
Member

FRidh commented Oct 2, 2018

We typically avoid renaming existing attributes, though I personally am not against doing the rename.

@jluttine
Copy link
Member Author

jluttine commented Oct 2, 2018 •
edited

Ok. And I've also understood that it's not ok to have an alias like nikola = Nikola, but is that so even in this case when it would keep the backwards compatibility while still providing the normalized name everyone should be expecting? I'm not comfortable breaking the backwards compatibility myself unless there's some consensus that the breaking should be done.

@jluttine
Copy link
Member Author

jluttine commented Oct 3, 2018 via email

@jluttine
Copy link
Member Author

@FRidh Just a kind reminder in case this has been forgotten. 🙂 In my view, this is ready for merging, but if there's anything I should do, please let me know.

@FRidh FRidh merged commit a4c0cdd into NixOS:master Oct 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

@FRidh FRidh FRidh requested changes

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jluttine @Mic92 @FRidh @GrahamcOfBorg