Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nvidia-x11: Fix vulkan VK_KHR_xcb_surface #46555

Merged
merged 1 commit into from Sep 16, 2018
Merged

nvidia-x11: Fix vulkan VK_KHR_xcb_surface #46555

merged 1 commit into from Sep 16, 2018

Conversation

danme
Copy link
Contributor

@danme danme commented Sep 12, 2018

Motivation for this change

Fixes the issue: #39149

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@danme
nvidia-x11: Fix vulkan VK_KHR_xcb_surface
bda072c 
Fixes the issue: NixOS#39149

Problem was that the Nvidia driver did not find the libxcb-glx at runtime.
infinisil
infinisil approved these changes Sep 16, 2018
View reviewed changes
Copy link
Member

@infinisil infinisil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can confirm that this does indeed fix it

@infinisil infinisil merged commit 9214a3e into NixOS:release-18.03 Sep 16, 2018
@infinisil infinisil mentioned this pull request Sep 16, 2018
Closed
@danme
Copy link
Contributor Author

danme commented Sep 17, 2018

Hey @infinisil,
I just realized that I created the PR for release-18.03 branch only, do I have to create a PR for the other branches (18.09 and master) as well?

@infinisil
Copy link
Member

@danme Ah yeah I didn't notice, yeah please open another 2 PRs for the other branches, I'll merge them after some trivial checks

@infinisil
Copy link
Member

@danme Oh and when you cherry-pick, please use -x and add a small reason for the cherry-pick

This was referenced Sep 23, 2018
Merged
Merged
@danme
Copy link
Contributor Author

danme commented Sep 23, 2018

@infinisil
I have created both PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil infinisil approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 11-100 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@danme @infinisil @GrahamcOfBorg @Janik-Haag