Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lollypop: wrap search provider #46559

Merged
merged 1 commit into from Sep 14, 2018
Merged

lollypop: wrap search provider #46559

merged 1 commit into from Sep 14, 2018

Conversation

worldofpeace
Copy link
Contributor

Motivation for this change

The gnome search provider was not wrapped at $out/libexec/lollypop-sp.

Also #43742 died of staleness 馃槃

@jtojnar
Maybe using python.pkgs.buildPythonApplication would be better

I've made this change 馃憤

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@jtojnar
Copy link
Contributor

jtojnar commented Sep 14, 2018

@GrahamcOfBorg build lollypop

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: lollypop

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: lollypop

Partial log (click to expand)

Wrapping program /nix/store/nymqspqazmdkjvg8mka21gc6x8bckzs8-lollypop-0.9.522/bin/lollypop
Wrapping program /nix/store/nymqspqazmdkjvg8mka21gc6x8bckzs8-lollypop-0.9.522/libexec/lollypop-sp
shrinking RPATHs of ELF executables and libraries in /nix/store/nymqspqazmdkjvg8mka21gc6x8bckzs8-lollypop-0.9.522
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/nymqspqazmdkjvg8mka21gc6x8bckzs8-lollypop-0.9.522/lib  /nix/store/nymqspqazmdkjvg8mka21gc6x8bckzs8-lollypop-0.9.522/libexec  /nix/store/nymqspqazmdkjvg8mka21gc6x8bckzs8-lollypop-0.9.522/bin
patching script interpreter paths in /nix/store/nymqspqazmdkjvg8mka21gc6x8bckzs8-lollypop-0.9.522
checking for references to /build in /nix/store/nymqspqazmdkjvg8mka21gc6x8bckzs8-lollypop-0.9.522...
wrapping `/nix/store/nymqspqazmdkjvg8mka21gc6x8bckzs8-lollypop-0.9.522/bin/.lollypop-wrapped'...
wrapping `/nix/store/nymqspqazmdkjvg8mka21gc6x8bckzs8-lollypop-0.9.522/bin/.lollypop-cli-wrapped'...
/nix/store/nymqspqazmdkjvg8mka21gc6x8bckzs8-lollypop-0.9.522

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: lollypop

Partial log (click to expand)

Wrapping program /nix/store/ks3c8r8j4hak4pbqpmbdmjfd2jjv0wh0-lollypop-0.9.522/bin/lollypop
Wrapping program /nix/store/ks3c8r8j4hak4pbqpmbdmjfd2jjv0wh0-lollypop-0.9.522/libexec/lollypop-sp
shrinking RPATHs of ELF executables and libraries in /nix/store/ks3c8r8j4hak4pbqpmbdmjfd2jjv0wh0-lollypop-0.9.522
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/ks3c8r8j4hak4pbqpmbdmjfd2jjv0wh0-lollypop-0.9.522/lib  /nix/store/ks3c8r8j4hak4pbqpmbdmjfd2jjv0wh0-lollypop-0.9.522/libexec  /nix/store/ks3c8r8j4hak4pbqpmbdmjfd2jjv0wh0-lollypop-0.9.522/bin
patching script interpreter paths in /nix/store/ks3c8r8j4hak4pbqpmbdmjfd2jjv0wh0-lollypop-0.9.522
checking for references to /build in /nix/store/ks3c8r8j4hak4pbqpmbdmjfd2jjv0wh0-lollypop-0.9.522...
wrapping `/nix/store/ks3c8r8j4hak4pbqpmbdmjfd2jjv0wh0-lollypop-0.9.522/bin/.lollypop-wrapped'...
wrapping `/nix/store/ks3c8r8j4hak4pbqpmbdmjfd2jjv0wh0-lollypop-0.9.522/bin/.lollypop-cli-wrapped'...
/nix/store/ks3c8r8j4hak4pbqpmbdmjfd2jjv0wh0-lollypop-0.9.522

@jtojnar jtojnar merged commit 4555a01 into NixOS:master Sep 14, 2018
@worldofpeace worldofpeace deleted the lollypop-oopsie branch September 14, 2018 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@worldofpeace @jtojnar @GrahamcOfBorg