Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eolie: 0.9.35 -> 0.9.36 #46560

Merged
merged 1 commit into from Sep 12, 2018
Merged

eolie: 0.9.35 -> 0.9.36 #46560

merged 1 commit into from Sep 12, 2018

Conversation

worldofpeace
Copy link
Contributor

An update and use buildPythonApplication

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

Mic92
Mic92 reviewed Sep 12, 2018
View reviewed changes
pkgs/applications/networking/browsers/eolie/default.nix

pythonPath = with python36Packages; [
pythonPath = with python3.pkgs; [
beautifulsoup4
pycairo
pygobject3
python-dateutil
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It also says:

[INFO] 2018-09-12 08:04:46 PyFxA missing: pip3 install --user pyfxa
[INFO] 2018-09-12 08:04:46 Cyrpto missing: pip3 install --user pycrypto

on startup. Is this something we should worry about?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is for the firefox sync service. I haven't packaged those deps so the feature is disabled.
Nothing to worry about. 👍

@Mic92 Mic92 merged commit ca2395f into NixOS:master Sep 12, 2018
@Mic92
Copy link
Member

Mic92 commented Sep 12, 2018

backport: 362498c

@worldofpeace worldofpeace deleted the eolie/0.9.36 branch September 12, 2018 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@worldofpeace @Mic92 @GrahamcOfBorg