Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/git annex remote google #46554

Closed
wants to merge 5 commits into from

Conversation

poelzi
Copy link
Member

@poelzi poelzi commented Sep 11, 2018

Motivation for this change

add git-annex-remote-googledrive. This remote has more features then the rclone remote and allows you to export a repository to google drive.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

src = python3.pkgs.fetchPypi {
inherit pname version;
sha256 = "1vaycxmxhx8g797nzrnkmz5vbmjy4x7x3b7a2xb7yz6grgcxqgld";
};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By convention we also add a

# no tests
doCheck = false;

remark if a python package comes without tests.

@Mic92
Copy link
Member

Mic92 commented Sep 18, 2018

@GrahamcOfBorg build gitAndTools.git-annex-remote-googledrive python27Packages.annexremote python27Packages.pydrive python27Packages.tenacity python36Packages.annexremote python36Packages.pydrive python36Packages.tenacity

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: gitAndTools.git-annex-remote-googledrive, python27Packages.annexremote, python27Packages.pydrive, python27Packages.tenacity, python36Packages.annexremote, python36Packages.pydrive, python36Packages.tenacity

Partial log (click to expand)

reading manifest file 'git_annex_remote_googledrive.egg-info/SOURCES.txt'
reading manifest template 'MANIFEST.in'
writing manifest file 'git_annex_remote_googledrive.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
error: build of '/nix/store/cb1l4nglrwn75a39b93si8zy7wyc3sxn-python2.7-tenacity-5.0.2.drv' failed

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Attempted: gitAndTools.git-annex-remote-googledrive, python27Packages.annexremote, python27Packages.pydrive, python27Packages.tenacity, python36Packages.annexremote, python36Packages.pydrive, python36Packages.tenacity

Partial log (click to expand)

reading manifest file 'git_annex_remote_googledrive.egg-info/SOURCES.txt'
reading manifest template 'MANIFEST.in'
writing manifest file 'git_annex_remote_googledrive.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
error: build of '/nix/store/291qgryh7ydbjsgyx3wlxr5090vb3cbj-python2.7-tenacity-5.0.2.drv' failed

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: gitAndTools.git-annex-remote-googledrive, python27Packages.annexremote, python27Packages.pydrive, python27Packages.tenacity, python36Packages.annexremote, python36Packages.pydrive, python36Packages.tenacity

Partial log (click to expand)

reading manifest file 'git_annex_remote_googledrive.egg-info/SOURCES.txt'
reading manifest template 'MANIFEST.in'
writing manifest file 'git_annex_remote_googledrive.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
error: build of '/nix/store/1zlfj2iz218g6drjndd9xchvci4gf8xm-python2.7-tenacity-5.0.2.drv' failed

@Mic92
Copy link
Member

Mic92 commented Sep 18, 2018

this should be fixed:

Processing ./tenacity-5.0.2-py2.py3-none-any.whl
Collecting monotonic>=0.6; python_version == "2.7" (from tenacity==5.0.2)
  Could not find a version that satisfies the requirement monotonic>=0.6; python_version == "2.7" (from tenacity==5.0.2) (from versions: )
No matching distribution found for monotonic>=0.6; python_version == "2.7" (from tenacity==5.0.

@@ -0,0 +1,22 @@
#{ stdenv, pythonPackages, fetchPypi, rclone, makeWrapper }:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove

sha256 = "1vaycxmxhx8g797nzrnkmz5vbmjy4x7x3b7a2xb7yz6grgcxqgld";
};

buildInputs = [ ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove


meta = with stdenv.lib; {
homepage = https://github.com/googledrive/PyDrive;
description = "PyDrive is a wrapper library of google-api-python-client that simplifies many common Google Drive API tasks";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't repeat name of package


meta = with stdenv.lib; {
homepage = https://github.com/jd/tenacity;
description = "Retrying library for Python";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Routines for retrying code"

@mmahut
Copy link
Member

mmahut commented Aug 9, 2019

Any updates on this pull request, please?

@stale
Copy link

stale bot commented Jun 1, 2020

Thank you for your contributions.
This has been automatically marked as stale because it has had no activity for 180 days.
If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.
Here are suggestions that might help resolve this more quickly:

  1. Search for maintainers and people that previously touched the
    related code and @ mention them in a comment.
  2. Ask on the NixOS Discourse. 3. Ask on the #nixos channel on
    irc.freenode.net.

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 1, 2020
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Oct 3, 2020
@Mindavi
Copy link
Contributor

Mindavi commented May 19, 2021

Has been added in pkgs/applications/version-management/git-and-tools/git-annex-remote-googledrive/default.nix, see also linked PR.

@Mindavi Mindavi closed this May 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants