Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubernetes: 1.10.5 -> 1.11.3 #46573

Merged
merged 1 commit into from Sep 13, 2018
Merged

kubernetes: 1.10.5 -> 1.11.3 #46573

merged 1 commit into from Sep 13, 2018

Conversation

johanot
Copy link
Contributor

@johanot johanot commented Sep 12, 2018

Motivation for this change

Since #45670 will not make it to 18.09, I'm PR'ing the kubernetes package separately. I'd like it if this could be backported to NixOS 18.09.

Even though this PR has no module updates, the main purpose of issue #43882 was to upgrade to v1.11, thus:
closes #43882

@srhb ping

Things done

NixOS tests for rbac and dns runs clean.

I've also tested this with a three node cluster in Google Cloud and it turns out that the existing kubernetes module works seamlessly with the 1.11.3 package, although some of the k8s components yield warnings for deprecated flags.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

kubernetes: 1.10.5 -> 1.11.3
a49f56c 
Fixed minor issue where kube-addon manager complaints about
/opt/namespace.yaml missing.

Added release notes with reference to Kubernetes 1.11 release notes.

closes NixOS#43882
@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: kubernetes

Partial log (click to expand)

strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/q17786b5b5zfbvrmxf7jmiy55xy8rifn-kubernetes-1.11.3-man
checking for references to /build in /nix/store/q17786b5b5zfbvrmxf7jmiy55xy8rifn-kubernetes-1.11.3-man...
shrinking RPATHs of ELF executables and libraries in /nix/store/cqqs70riij9k63pklbq8a5i2f1abjlc7-kubernetes-1.11.3-pause
shrinking /nix/store/cqqs70riij9k63pklbq8a5i2f1abjlc7-kubernetes-1.11.3-pause/bin/pause
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/cqqs70riij9k63pklbq8a5i2f1abjlc7-kubernetes-1.11.3-pause/bin
patching script interpreter paths in /nix/store/cqqs70riij9k63pklbq8a5i2f1abjlc7-kubernetes-1.11.3-pause
checking for references to /build in /nix/store/cqqs70riij9k63pklbq8a5i2f1abjlc7-kubernetes-1.11.3-pause...
/nix/store/fn5liqgvy3yjq77jksp2y8ajanqclnyc-kubernetes-1.11.3

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: kubernetes

Partial log (click to expand)

strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/465g2lxzl9asczpbl3k6fgmrqqnawhds-kubernetes-1.11.3-man
checking for references to /build in /nix/store/465g2lxzl9asczpbl3k6fgmrqqnawhds-kubernetes-1.11.3-man...
shrinking RPATHs of ELF executables and libraries in /nix/store/9rg029r9aqgzj4ciggqhcy5xsj87zb6f-kubernetes-1.11.3-pause
shrinking /nix/store/9rg029r9aqgzj4ciggqhcy5xsj87zb6f-kubernetes-1.11.3-pause/bin/pause
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/9rg029r9aqgzj4ciggqhcy5xsj87zb6f-kubernetes-1.11.3-pause/bin
patching script interpreter paths in /nix/store/9rg029r9aqgzj4ciggqhcy5xsj87zb6f-kubernetes-1.11.3-pause
checking for references to /build in /nix/store/9rg029r9aqgzj4ciggqhcy5xsj87zb6f-kubernetes-1.11.3-pause...
/nix/store/bzcvswk3asyf91a2rdqldx3mdihy7kgv-kubernetes-1.11.3

@johanot
Copy link
Contributor Author

johanot commented Sep 12, 2018

@GrahamcOfBorg test kubernetes.rbac.singlenode kubernetes.dns.singlenode kubernetes.rbac.multinode kubernetes.dns.multinode

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: tests.kubernetes.rbac.singlenode, tests.kubernetes.dns.singlenode, tests.kubernetes.rbac.multinode, tests.kubernetes.dns.multinode

Partial log (click to expand)


Cannot nix-instantiate `tests.kubernetes.dns.singlenode' because:
error: attribute 'singlenode' in selection path 'tests.kubernetes.dns.singlenode' not found

Cannot nix-instantiate `tests.kubernetes.rbac.multinode' because:
error: attribute 'multinode' in selection path 'tests.kubernetes.rbac.multinode' not found

Cannot nix-instantiate `tests.kubernetes.dns.multinode' because:
error: attribute 'multinode' in selection path 'tests.kubernetes.dns.multinode' not found

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: tests.kubernetes.rbac.singlenode, tests.kubernetes.dns.singlenode, tests.kubernetes.rbac.multinode, tests.kubernetes.dns.multinode

Partial log (click to expand)

machine1: exit status 0
test script finished in 83.14s
cleaning up
killing machine1 (pid 597)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/np2c4zfrrhrjg4772arh5dbjpjc3g3iv-vm-test-run-kubernetes-rbac-singlenode
/nix/store/99nncfp5nq5jlgp77dlzi57930j00df4-vm-test-run-kubernetes-dns-singlenode
/nix/store/47iax0npzcxjizirmzcsrciryjkvyx1y-vm-test-run-kubernetes-rbac-multinode
/nix/store/96h5fg49s29wpwkw5qpxh76bz8hhm9lk-vm-test-run-kubernetes-dns-multinode

@srhb srhb merged commit d024f91 into NixOS:master Sep 13, 2018
@srhb srhb mentioned this pull request Sep 13, 2018
Merged
9 tasks
@johanot johanot deleted the kubernetes-1.10-1.11 branch September 13, 2018 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: changelog 8.has: documentation 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Kubernetes 1.10 -> 1.11
3 participants
@johanot @GrahamcOfBorg @srhb