prometheus-alertmanager module: implement meshing #46571
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mic92
reviewed
Sep 12, 2018
| users.extraGroups."${cfg.group}" = { }; | ||
|
|
||
| systemd.tmpfiles.rules = [ | ||
| "d ${cfg.stateDir} 0770 ${cfg.user} ${cfg.group} -" |
There was a problem hiding this comment.
RuntimeDirectory provided by systemd might be better.
Mic92
reviewed
Sep 12, 2018
| description = '' | ||
| User name under which Alertmanager shall be run. | ||
| ''; | ||
| }; | ||
|
|
||
| group = mkOption { | ||
| type = types.str; | ||
| default = "nogroup"; | ||
| default = "alertmanager"; |
There was a problem hiding this comment.
If it does not matter, DynamicUser might be an option.
|
Behaviour changed in current alertmanager version, closing for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Allow meshing in the prometheus alertmanager module.
This has been used in production for quite some time and we just missed upstreaming it.
Therefore, and due to it being a rather small change, I propose backporting to 18.09 (cc @vcunat, @samueldr)
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)