New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for pytorch-0.4.1 cuda-enabled build. #46562
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Maybe I don't understand the issue here. According to hydra https://hydra.nixos.org/jobset/nixpkgs/trunk/jobs-tab?filter=pytorch pytorch builds just fine. |
Thanks for explaning. The |
GrahamcOfBorg
added
6.topic: emacs
6.topic: haskell
6.topic: nixos
6.topic: qt/kde
6.topic: steam
6.topic: vim
8.has: documentation
8.has: module (update)
2.status: merge conflict
and removed
6.topic: emacs
6.topic: haskell
6.topic: nixos
6.topic: qt/kde
6.topic: steam
6.topic: vim
8.has: documentation
8.has: module (update)
2.status: merge conflict
labels
Sep 18, 2018
GrahamcOfBorg
added
6.topic: stdenv
Standard environment
8.has: changelog
8.has: documentation
8.has: module (update)
10.rebuild-darwin-stdenv
10.rebuild-linux-stdenv
8.has: clean-up
8.has: package (new)
10.rebuild-darwin: 501+
10.rebuild-darwin: 101-500
and removed
6.topic: GNOME
GNOME desktop environment and its underlying platform
6.topic: nixos
6.topic: rust
6.topic: stdenv
Standard environment
8.has: changelog
8.has: documentation
8.has: module (update)
10.rebuild-darwin: 101-500
10.rebuild-darwin-stdenv
10.rebuild-linux-stdenv
10.rebuild-darwin: 501+
labels
Sep 19, 2018
@xeji I rebased PR and checked to make sure it builds on staging with and without cuda. |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported at #46032 pytorch build currently fails. The reason, I believe, is ongoing pytorch and libcaffe merge and related dependencies problems. Basically this patch fixes hard-coded dependency inside build directory.
Also openblas was updated because autograd tests failed with older version, see pytorch/pytorch#11133. Patches were merged into upstream and no longer necessary.