Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

android-file-transfer: 3.4 -> 3.5 #46570

Merged
merged 1 commit into from Sep 12, 2018
Merged

android-file-transfer: 3.4 -> 3.5 #46570

merged 1 commit into from Sep 12, 2018

Conversation

dywedir
Copy link
Member

@dywedir dywedir commented Sep 12, 2018

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

cc @xaverdh

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: android-file-transfer

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/rscq1imnzfmrhw02nhjq0sd1gqllpj9p-android-file-transfer-3.5
shrinking /nix/store/rscq1imnzfmrhw02nhjq0sd1gqllpj9p-android-file-transfer-3.5/bin/aft-mtp-cli
shrinking /nix/store/rscq1imnzfmrhw02nhjq0sd1gqllpj9p-android-file-transfer-3.5/bin/aft-mtp-mount
shrinking /nix/store/rscq1imnzfmrhw02nhjq0sd1gqllpj9p-android-file-transfer-3.5/bin/android-file-transfer
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/rscq1imnzfmrhw02nhjq0sd1gqllpj9p-android-file-transfer-3.5/lib  /nix/store/rscq1imnzfmrhw02nhjq0sd1gqllpj9p-android-file-transfer-3.5/bin
patching script interpreter paths in /nix/store/rscq1imnzfmrhw02nhjq0sd1gqllpj9p-android-file-transfer-3.5
checking for references to /build in /nix/store/rscq1imnzfmrhw02nhjq0sd1gqllpj9p-android-file-transfer-3.5...
postPatchMkspecs
/nix/store/rscq1imnzfmrhw02nhjq0sd1gqllpj9p-android-file-transfer-3.5

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: android-file-transfer

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/gsd5pkgglxmnzdqmmmrq9ahap72lh2lf-android-file-transfer-3.5
shrinking /nix/store/gsd5pkgglxmnzdqmmmrq9ahap72lh2lf-android-file-transfer-3.5/bin/android-file-transfer
shrinking /nix/store/gsd5pkgglxmnzdqmmmrq9ahap72lh2lf-android-file-transfer-3.5/bin/aft-mtp-mount
shrinking /nix/store/gsd5pkgglxmnzdqmmmrq9ahap72lh2lf-android-file-transfer-3.5/bin/aft-mtp-cli
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/gsd5pkgglxmnzdqmmmrq9ahap72lh2lf-android-file-transfer-3.5/lib  /nix/store/gsd5pkgglxmnzdqmmmrq9ahap72lh2lf-android-file-transfer-3.5/bin
patching script interpreter paths in /nix/store/gsd5pkgglxmnzdqmmmrq9ahap72lh2lf-android-file-transfer-3.5
checking for references to /build in /nix/store/gsd5pkgglxmnzdqmmmrq9ahap72lh2lf-android-file-transfer-3.5...
postPatchMkspecs
/nix/store/gsd5pkgglxmnzdqmmmrq9ahap72lh2lf-android-file-transfer-3.5

@xaverdh
Copy link
Contributor

xaverdh commented Sep 12, 2018

Looks good to me

@Mic92 Mic92 merged commit 9a70738 into NixOS:master Sep 12, 2018
@dywedir dywedir deleted the android-file-transfer branch September 12, 2018 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dywedir @GrahamcOfBorg @xaverdh @Mic92