Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mosquitto: ipv6 and tls cert store fixes #46572

Closed
wants to merge 2 commits into from
Closed

mosquitto: ipv6 and tls cert store fixes #46572

wants to merge 2 commits into from

Conversation

globin
Copy link
Member

@globin globin commented Sep 12, 2018

Motivation for this change

This fixes mosquitto not listening by default on IPv6 and not finding the cert store by default.

I propose backporting this to 18.09 (cc @vcunat, @samueldr)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • N/A macOS
    • N/A other Linux distributions
  • N/A Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • N/A Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • N/A Tested execution of all binary files (usually in ./result/bin/)
  • N/A Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: mosquitto

Partial log (click to expand)

these paths will be fetched (0.14 MiB download, 0.47 MiB unpacked):
  /nix/store/vrc7yb3hc9d4gbpslgiipggrdhf0iyzg-mosquitto-1.4.15
copying path '/nix/store/vrc7yb3hc9d4gbpslgiipggrdhf0iyzg-mosquitto-1.4.15' from 'https://cache.nixos.org'...
/nix/store/vrc7yb3hc9d4gbpslgiipggrdhf0iyzg-mosquitto-1.4.15

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: mosquitto

Partial log (click to expand)

these paths will be fetched (3.06 MiB download, 5.22 MiB unpacked):
  /nix/store/94i1s4ikyykc4dj632msvjcjhqy7lj4p-mosquitto-1.4.15
  /nix/store/v8282p3al633vs3xqahxkp815gz2162j-libwebsockets-3.0.0
copying path '/nix/store/v8282p3al633vs3xqahxkp815gz2162j-libwebsockets-3.0.0' from 'https://cache.nixos.org'...
copying path '/nix/store/94i1s4ikyykc4dj632msvjcjhqy7lj4p-mosquitto-1.4.15' from 'https://cache.nixos.org'...
/nix/store/94i1s4ikyykc4dj632msvjcjhqy7lj4p-mosquitto-1.4.15

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: mosquitto

Partial log (click to expand)

these paths will be fetched (3.10 MiB download, 5.40 MiB unpacked):
  /nix/store/1czm3kr700s7834vmlifx7jwwc950w6f-libwebsockets-3.0.0
  /nix/store/xck9ndq8x0qlg94027a626cc1dyx86vn-mosquitto-1.4.15
copying path '/nix/store/1czm3kr700s7834vmlifx7jwwc950w6f-libwebsockets-3.0.0' from 'https://cache.nixos.org'...
copying path '/nix/store/xck9ndq8x0qlg94027a626cc1dyx86vn-mosquitto-1.4.15' from 'https://cache.nixos.org'...
/nix/store/xck9ndq8x0qlg94027a626cc1dyx86vn-mosquitto-1.4.15

@globin globin closed this Sep 15, 2018
@vcunat
Copy link
Member

vcunat commented Sep 23, 2018 •
edited

@globin: you closed this without merging or explanation?

@globin
Copy link
Member Author

globin commented Sep 23, 2018

This uncovered a bug in the mosquitto networking code I have to look at first..

@globin globin deleted the mosquitto-ip6 branch September 23, 2018 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@globin @GrahamcOfBorg @vcunat