Make sure that the machine is UP before trying to destroy it in GCP #1002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This can cause problems since we issue API call without actually checking if the node is up or not. One easy way to see the manifestation of this bug is to create a deployment with a machine that has underscore in it's name (It's not supported in GCP). And without even deploying, try to destroy it. The expected behavior is nothing! Since the machine is down. However, an exception is raised because nixops tries to call the API to get the node.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can cause problems since we issue API call without actually checking
if the node is up or not. One easy way to see the manifestation of this
bug is to create a deployment with a machine that has underscore in
it's name (It's not supported in GCP). And without even deploying,
try to destroy it. The expected behavior is nothing! Since the
machine is down. However, an exception is raised because nixops tries
to call the API to get the node.