Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nix-review: 0.5.0 -> 0.5.2 #45770

Merged
merged 1 commit into from
Aug 30, 2018
Merged

nix-review: 0.5.0 -> 0.5.2 #45770

merged 1 commit into from
Aug 30, 2018

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Aug 30, 2018

fix cleanup issue: Mic92/nixpkgs-review#10
fix overriding NIXPKGS_CONFIG: Mic92/nixpkgs-review#12

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip" nix-review pr 45770
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: nix-review

Partial log (click to expand)

$ git worktree prune
$ git fetch --force https://github.com/NixOS/nixpkgs master:refs/nix-review/0 pull/1/head:refs/nix-review/1
$ git worktree add ./.review/pr-1 hash1
$ git merge --no-commit hash2
Building in /private/tmp/nix-build-nix-review-0.5.1.drv-0/nox-review-vic5g0dc: pong3d
$ nix-shell --no-out-link --keep-going --max-jobs 8 --option build-use-sandbox true --run true --builders ssh://joerg@10.243.29.170 aarch64-linux -p pong3d
https://github.com/NixOS/nixpkgs/pull/1
$ nix-shell -p pong3d
$ git worktree prune
/nix/store/15amlrv95ic1w1p7wms0d9ih71pm50xp-nix-review-0.5.1

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: nix-review

Partial log (click to expand)

$ git worktree prune
$ git fetch --force https://github.com/NixOS/nixpkgs master:refs/nix-review/0 pull/1/head:refs/nix-review/1
$ git worktree add ./.review/pr-1 hash1
$ git merge --no-commit hash2
Building in /build/nox-review-0avr2ejj: pong3d
$ nix-shell --no-out-link --keep-going --max-jobs 96 --option build-use-sandbox true --run true --builders ssh://joerg@10.243.29.170 aarch64-linux -p pong3d
https://github.com/NixOS/nixpkgs/pull/1
$ nix-shell -p pong3d
$ git worktree prune
/nix/store/v4myyhkyqy7dfp9qzdycjrb07r5b99rx-nix-review-0.5.1

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: nix-review

Partial log (click to expand)

$ git worktree prune
$ git fetch --force https://github.com/NixOS/nixpkgs master:refs/nix-review/0 pull/1/head:refs/nix-review/1
$ git worktree add ./.review/pr-1 hash1
$ git merge --no-commit hash2
Building in /build/nox-review-djctwhjo: pong3d
$ nix-shell --no-out-link --keep-going --max-jobs 4 --option build-use-sandbox true --run true --builders ssh://joerg@10.243.29.170 aarch64-linux -p pong3d
https://github.com/NixOS/nixpkgs/pull/1
$ nix-shell -p pong3d
$ git worktree prune
/nix/store/pqb0j1lrvm19pbfsb4fxl6zgs9a0hi7y-nix-review-0.5.1

@Mic92 Mic92 force-pushed the nix-review-0.5.1 branch from 0b0bf23 to 5b452a2 Compare August 30, 2018 06:39
@Mic92 Mic92 changed the title nix-review: 0.5.0 -> 0.5.1 nix-review: 0.5.0 -> 0.5.2 Aug 30, 2018
@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: nix-review

Partial log (click to expand)

$ git worktree prune
$ git fetch --force https://github.com/NixOS/nixpkgs master:refs/nix-review/0 pull/1/head:refs/nix-review/1
$ git worktree add ./.review/pr-1 hash1
$ git merge --no-commit hash2
Building in /build/nox-review-z468qjep: pong3d
$ nix-shell --no-out-link --keep-going --max-jobs 96 --option build-use-sandbox true --run true --builders ssh://joerg@10.243.29.170 aarch64-linux -p pong3d
https://github.com/NixOS/nixpkgs/pull/1
$ nix-shell -p pong3d
$ git worktree prune
/nix/store/n7rqz69585xcg071hxwvggc1s0b7j18c-nix-review-0.5.2

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: nix-review

Partial log (click to expand)

$ git worktree prune
$ git fetch --force https://github.com/NixOS/nixpkgs master:refs/nix-review/0 pull/1/head:refs/nix-review/1
$ git worktree add ./.review/pr-1 hash1
$ git merge --no-commit hash2
Building in /build/nox-review-4ymyaeub: pong3d
$ nix-shell --no-out-link --keep-going --max-jobs 8 --option build-use-sandbox true --run true --builders ssh://joerg@10.243.29.170 aarch64-linux -p pong3d
https://github.com/NixOS/nixpkgs/pull/1
$ nix-shell -p pong3d
$ git worktree prune
/nix/store/g9cbv42jh2hv8zk75iifbqn8inrlprd5-nix-review-0.5.2

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: nix-review

Partial log (click to expand)

$ git worktree prune
$ git fetch --force https://github.com/NixOS/nixpkgs master:refs/nix-review/0 pull/1/head:refs/nix-review/1
$ git worktree add ./.review/pr-1 hash1
$ git merge --no-commit hash2
Building in /private/tmp/nix-build-nix-review-0.5.2.drv-0/nox-review-q_52piiu: pong3d
$ nix-shell --no-out-link --keep-going --max-jobs 2 --option build-use-sandbox true --run true --builders ssh://joerg@10.243.29.170 aarch64-linux -p pong3d
https://github.com/NixOS/nixpkgs/pull/1
$ nix-shell -p pong3d
$ git worktree prune
/nix/store/2lgq4qi4mk9apgi58gm6n4np5bchxsdq-nix-review-0.5.2

@xeji xeji merged commit 29b48e0 into NixOS:master Aug 30, 2018
@Mic92 Mic92 deleted the nix-review-0.5.1 branch August 30, 2018 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants