linux_testing_bcachefs: 4.16.2018.08.03 -> 4.18.2018.08.31 #45774

Chiiruno · 2018-08-30T09:07:22Z

Motivation for this change

Fixes #45769

Things done

Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Determined the impact on package closure size (by running nix path-info -S before and after)
Fits CONTRIBUTING.md.

Mic92 · 2018-08-30T09:50:19Z

@GrahamcOfBorg build bcachefs-tools

GrahamcOfBorg · 2018-08-30T09:50:45Z

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: bcachefs-tools

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

GrahamcOfBorg · 2018-08-30T09:51:03Z

Success on aarch64-linux (full log)

Attempted: bcachefs-tools

Partial log (click to expand)

strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/jafq0fmslgvqihxp0dn6hrbfdyn8d1zp-bcachefs-tools-unstable-2018-08-22/sbin
patching script interpreter paths in /nix/store/jafq0fmslgvqihxp0dn6hrbfdyn8d1zp-bcachefs-tools-unstable-2018-08-22
/nix/store/jafq0fmslgvqihxp0dn6hrbfdyn8d1zp-bcachefs-tools-unstable-2018-08-22/etc/initramfs-tools/scripts/local-premount/bcachefs: interpreter directive changed from "/bin/sh" to "/nix/store/fqm2x6kiay1q4vg7pqp4wp17bdijlyc3-bash-4.4-p23/bin/sh"
/nix/store/jafq0fmslgvqihxp0dn6hrbfdyn8d1zp-bcachefs-tools-unstable-2018-08-22/etc/initramfs-tools/hooks/bcachefs: interpreter directive changed from "/bin/sh" to "/nix/store/fqm2x6kiay1q4vg7pqp4wp17bdijlyc3-bash-4.4-p23/bin/sh"
/nix/store/jafq0fmslgvqihxp0dn6hrbfdyn8d1zp-bcachefs-tools-unstable-2018-08-22/sbin/mkfs.bcachefs: interpreter directive changed from "/bin/sh" to "/nix/store/fqm2x6kiay1q4vg7pqp4wp17bdijlyc3-bash-4.4-p23/bin/sh"
/nix/store/jafq0fmslgvqihxp0dn6hrbfdyn8d1zp-bcachefs-tools-unstable-2018-08-22/sbin/fsck.bcachefs: interpreter directive changed from "/bin/sh" to "/nix/store/fqm2x6kiay1q4vg7pqp4wp17bdijlyc3-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/jafq0fmslgvqihxp0dn6hrbfdyn8d1zp-bcachefs-tools-unstable-2018-08-22...
moving /nix/store/jafq0fmslgvqihxp0dn6hrbfdyn8d1zp-bcachefs-tools-unstable-2018-08-22/sbin/* to /nix/store/jafq0fmslgvqihxp0dn6hrbfdyn8d1zp-bcachefs-tools-unstable-2018-08-22/bin
/nix/store/jafq0fmslgvqihxp0dn6hrbfdyn8d1zp-bcachefs-tools-unstable-2018-08-22

Mic92 · 2018-08-30T09:51:04Z

Let's see if we can make it in time:

@GrahamcOfBorg build linux_testing_bcachefs

GrahamcOfBorg · 2018-08-30T09:51:15Z

Success on x86_64-linux (full log)

Attempted: bcachefs-tools

Partial log (click to expand)

strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/sf6m7x3m4vr8x69rqz4vj65nx8xc85c0-bcachefs-tools-unstable-2018-08-22/sbin
patching script interpreter paths in /nix/store/sf6m7x3m4vr8x69rqz4vj65nx8xc85c0-bcachefs-tools-unstable-2018-08-22
/nix/store/sf6m7x3m4vr8x69rqz4vj65nx8xc85c0-bcachefs-tools-unstable-2018-08-22/etc/initramfs-tools/scripts/local-premount/bcachefs: interpreter directive changed from "/bin/sh" to "/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/sh"
/nix/store/sf6m7x3m4vr8x69rqz4vj65nx8xc85c0-bcachefs-tools-unstable-2018-08-22/etc/initramfs-tools/hooks/bcachefs: interpreter directive changed from "/bin/sh" to "/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/sh"
/nix/store/sf6m7x3m4vr8x69rqz4vj65nx8xc85c0-bcachefs-tools-unstable-2018-08-22/sbin/fsck.bcachefs: interpreter directive changed from "/bin/sh" to "/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/sh"
/nix/store/sf6m7x3m4vr8x69rqz4vj65nx8xc85c0-bcachefs-tools-unstable-2018-08-22/sbin/mkfs.bcachefs: interpreter directive changed from "/bin/sh" to "/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/sf6m7x3m4vr8x69rqz4vj65nx8xc85c0-bcachefs-tools-unstable-2018-08-22...
moving /nix/store/sf6m7x3m4vr8x69rqz4vj65nx8xc85c0-bcachefs-tools-unstable-2018-08-22/sbin/* to /nix/store/sf6m7x3m4vr8x69rqz4vj65nx8xc85c0-bcachefs-tools-unstable-2018-08-22/bin
/nix/store/sf6m7x3m4vr8x69rqz4vj65nx8xc85c0-bcachefs-tools-unstable-2018-08-22

GrahamcOfBorg · 2018-08-30T09:51:33Z

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: linux_testing_bcachefs

Partial log (click to expand)

Cannot nix-instantiate `linux_testing_bcachefs' because:
error: while evaluating 'callPackageWith' at /private/var/lib/ofborg/builds/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/lib/customisation.nix:108:35, called from /private/var/lib/ofborg/builds/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/pkgs/top-level/all-packages.nix:14005:28:
while evaluating 'makeOverridable' at /private/var/lib/ofborg/builds/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/lib/customisation.nix:67:24, called from /private/var/lib/ofborg/builds/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/lib/customisation.nix:112:8:
while evaluating anonymous function at /private/var/lib/ofborg/builds/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/pkgs/os-specific/linux/kernel/linux-testing-bcachefs.nix:1:1, called from /private/var/lib/ofborg/builds/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/lib/customisation.nix:69:12:
while evaluating 'buildLinux' at /private/var/lib/ofborg/builds/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/pkgs/top-level/all-packages.nix:14284:16, called from /private/var/lib/ofborg/builds/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/pkgs/os-specific/linux/kernel/linux-testing-bcachefs.nix:3:1:
while evaluating 'callPackageWith' at /private/var/lib/ofborg/builds/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/lib/customisation.nix:108:35, called from /private/var/lib/ofborg/builds/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/pkgs/top-level/all-packages.nix:14284:23:
while evaluating 'makeOverridable' at /private/var/lib/ofborg/builds/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/lib/customisation.nix:67:24, called from /private/var/lib/ofborg/builds/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/lib/customisation.nix:112:8:
while evaluating anonymous function at /private/var/lib/ofborg/builds/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/pkgs/os-specific/linux/kernel/generic.nix:1:1, called from /private/var/lib/ofborg/builds/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/lib/customisation.nix:69:12:
assertion failed at /private/var/lib/ofborg/builds/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/pkgs/os-specific/linux/kernel/generic.nix:52:1

GrahamcOfBorg · 2018-08-30T10:06:56Z

Failure on aarch64-linux (full log)

Attempted: linux_testing_bcachefs

Partial log (click to expand)

  CC [M]  drivers/gpu/drm/nouveau/nv84_fence.o
  CC [M]  drivers/gpu/drm/nouveau/nvc0_fence.o
  LD [M]  drivers/gpu/drm/nouveau/nouveau.o
  AR      drivers/gpu/drm/built-in.a
  AR      drivers/gpu/built-in.a
  AR      drivers/built-in.a
make[1]: *** [Makefile:146: sub-make] Error 2
make: *** [Makefile:24: __sub-make] Error 2
builder for '/nix/store/n4z5jwqy1cggpwrkzvfpv8knvlxyz3qp-linux-4.18.2018.08.21.drv' failed with exit code 2
error: build of '/nix/store/n4z5jwqy1cggpwrkzvfpv8knvlxyz3qp-linux-4.18.2018.08.21.drv' failed

Mic92 · 2018-08-30T10:11:56Z

@Chiiruno please disable aarch64 support for this kernel:

extraMeta.platforms = [ "x86_64-linux" ];

Chiiruno · 2018-08-30T10:14:55Z

@Mic92 Done.

vcunat · 2018-08-30T10:27:42Z

Well, the kernel builds on my x86_64-linux, but this is more about using it with the FS :-)

GrahamcOfBorg · 2018-08-30T10:30:33Z

Timed out, unknown build status on x86_64-linux (full log)

Attempted: linux_testing_bcachefs

Partial log (click to expand)

  CC [M]  drivers/tty/synclinkmp.o
  CC [M]  drivers/scsi/qla2xxx/qla_mr.o
  CC [M]  drivers/usb/gadget/udc/dummy_hcd.o
  CC [M]  drivers/staging/rtl8192e/rtl8192e/rtl_pm.o
  CC [M]  drivers/staging/rtl8192e/rtl8192e/rtl_ps.o
  CC [M]  drivers/usb/gadget/udc/net2272.o
  CC [M]  drivers/scsi/qla2xxx/qla_nx2.o
  CC [M]  drivers/staging/rtl8192e/rtl8192e/rtl_wx.o
building of '/nix/store/b0w47fp0l4dg46v0fd6pjscz5ndfy9n9-linux-4.18.2018.08.21.drv' timed out after 1800 seconds
error: build of '/nix/store/b0w47fp0l4dg46v0fd6pjscz5ndfy9n9-linux-4.18.2018.08.21.drv' failed

Chiiruno · 2018-08-30T10:31:24Z

@vcunat Yes, for me too.
Does nix have a way to streamline filesystem tests in a VM?
Is the build bot overloaded right now by any chance?

Mic92 · 2018-08-30T11:10:41Z

It is not overloaded probably but there is a one hour limit, this is ok to fail. I can build locally.

Mic92 · 2018-08-30T11:11:55Z

We have tests for the installer and zfs in nixpkgs/nixos/tests. Bcachefs can be added as well.

vcunat · 2018-08-30T11:30:08Z

For this merge I'm fine if the FS now works for you – you did test that, right? PR with a reasonably written VM test would surely get merged, too.

Chiiruno · 2018-08-30T11:32:07Z

@vcunat I only tested compilation and what was checked off in the OP.
I'm not savvy enough about nix vm to do that, unfortunately.
I have, however, tested bcachefs before, and it's worked, so I would assume this one does too, but (I hope) this probably means very little.

Chiiruno · 2018-08-30T11:33:36Z

If you want a VM test, it'll have to wait until tomorrow, but chances are you could merge this now and it would be fine.

Mic92 · 2018-08-30T12:06:12Z

I currently cannot test this either if this updates works (manually or automatically).

Mic92 · 2018-08-30T12:06:58Z

The build also works on my machine.

vcunat · 2018-08-30T12:49:17Z

Then I'd wait until someone runs the FS with this, on bare metal or VM.

Chiiruno · 2018-08-30T19:52:06Z

My apologies, I stopped using bcachefs after I lost a lot of data, ironically due to the error this commit supposedly fixes. I'll see what I can do about tests, and at the very least I'll run this in a standard VM now that I have the chance. (Is there a way to easily add an empty disk to a nixos vm, though?)

Chiiruno · 2018-08-30T21:03:08Z

@vcunat First time making a test, that was surprisingly easy.
Seems to work, this can be merged I think.

Mic92 · 2018-08-30T21:56:42Z

nixos/tests/bcachefs.nix

+        meta.maintainers = [ pkgs.stdenv.lib.maintainers.chiiruno ];
+    };
+in {
+  stable = makeBcachefsTest "stable" { };


if the test is supposed to be run by hydra, it should be also referenced in nixpkgs/nixos/release.nix

Chiiruno · 2018-08-30T22:40:58Z

@Mic92 All good?

GrahamcOfBorg added 8.has: clean-up 10.rebuild-darwin: 0 10.rebuild-linux: 11-100 labels Aug 30, 2018

Chiiruno force-pushed the dev/bcachefs branch from 8e9fed3 to d211a32 Compare August 30, 2018 10:14

Chiiruno mentioned this pull request Aug 30, 2018

Key sharing for bcachefs and ecryptfs #32279

Open

GrahamcOfBorg added the 6.topic: nixos label Aug 30, 2018

Mic92 reviewed Aug 30, 2018

View reviewed changes

Chiiruno force-pushed the dev/bcachefs branch from 8eec6ad to b70eaaf Compare August 30, 2018 22:39

Madouura added 3 commits August 31, 2018 21:19

linux_testing_bcachefs: 4.16.2018.08.03 -> 4.18.2018.08.31

b74ec60

bcachefs-tools: 2018-07-21 -> 2018-08-22

f7d1953

nixos/tests/bcachefs: init

3d1fecd

Chiiruno force-pushed the dev/bcachefs branch from b70eaaf to 3d1fecd Compare September 1, 2018 02:20

Chiiruno changed the title ~~linux_testing_bcachefs: 4.16.2018.08.03 -> 4.18.2018.08.21~~ linux_testing_bcachefs: 4.16.2018.08.03 -> 4.18.2018.08.31 Sep 1, 2018

vcunat approved these changes Sep 1, 2018

View reviewed changes

vcunat merged commit 3d1fecd into NixOS:master Sep 1, 2018

vcunat added a commit that referenced this pull request Sep 1, 2018

Merge #45774: linux_testing_bcachefs: upgrade, add tests

9b0649a

Chiiruno deleted the dev/bcachefs branch September 1, 2018 09:10

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

linux_testing_bcachefs: 4.16.2018.08.03 -> 4.18.2018.08.31 #45774

linux_testing_bcachefs: 4.16.2018.08.03 -> 4.18.2018.08.31 #45774

Chiiruno commented Aug 30, 2018 •

edited

Mic92 commented Aug 30, 2018

GrahamcOfBorg commented Aug 30, 2018

GrahamcOfBorg commented Aug 30, 2018

Mic92 commented Aug 30, 2018

GrahamcOfBorg commented Aug 30, 2018

GrahamcOfBorg commented Aug 30, 2018

GrahamcOfBorg commented Aug 30, 2018

Mic92 commented Aug 30, 2018

Chiiruno commented Aug 30, 2018

vcunat commented Aug 30, 2018

GrahamcOfBorg commented Aug 30, 2018

Chiiruno commented Aug 30, 2018 •

edited

Mic92 commented Aug 30, 2018

Mic92 commented Aug 30, 2018

vcunat commented Aug 30, 2018

Chiiruno commented Aug 30, 2018 •

edited

Chiiruno commented Aug 30, 2018

Mic92 commented Aug 30, 2018 •

edited

Mic92 commented Aug 30, 2018

vcunat commented Aug 30, 2018

Chiiruno commented Aug 30, 2018

Chiiruno commented Aug 30, 2018

Mic92 Aug 30, 2018

Chiiruno commented Aug 30, 2018

linux_testing_bcachefs: 4.16.2018.08.03 -> 4.18.2018.08.31 #45774

linux_testing_bcachefs: 4.16.2018.08.03 -> 4.18.2018.08.31 #45774

Conversation

Chiiruno commented Aug 30, 2018 • edited

Motivation for this change

Things done

Mic92 commented Aug 30, 2018

GrahamcOfBorg commented Aug 30, 2018

GrahamcOfBorg commented Aug 30, 2018

Mic92 commented Aug 30, 2018

GrahamcOfBorg commented Aug 30, 2018

GrahamcOfBorg commented Aug 30, 2018

GrahamcOfBorg commented Aug 30, 2018

Mic92 commented Aug 30, 2018

Chiiruno commented Aug 30, 2018

vcunat commented Aug 30, 2018

GrahamcOfBorg commented Aug 30, 2018

Chiiruno commented Aug 30, 2018 • edited

Mic92 commented Aug 30, 2018

Mic92 commented Aug 30, 2018

vcunat commented Aug 30, 2018

Chiiruno commented Aug 30, 2018 • edited

Chiiruno commented Aug 30, 2018

Mic92 commented Aug 30, 2018 • edited

Mic92 commented Aug 30, 2018

vcunat commented Aug 30, 2018

Chiiruno commented Aug 30, 2018

Chiiruno commented Aug 30, 2018

Mic92 Aug 30, 2018

Choose a reason for hiding this comment

Chiiruno commented Aug 30, 2018

Chiiruno commented Aug 30, 2018 •

edited

Chiiruno commented Aug 30, 2018 •

edited

Chiiruno commented Aug 30, 2018 •

edited

Mic92 commented Aug 30, 2018 •

edited