Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

swift: 4.1 -> 4.1.3 #45777

Merged
merged 1 commit into from Sep 3, 2018
Merged

swift: 4.1 -> 4.1.3 #45777

merged 1 commit into from Sep 3, 2018

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Aug 30, 2018

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: swift

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: swift

Partial log (click to expand)

                 ^
Foundation/HTTPCookie.swift:271:18: note: use 'compactMap(_:)' instead
                .flatMap { Int(String($0)) }
                 ^~~~~~~
                 compactMap
ninja: build stopped: subcommand failed.
/build/src/swift/utils/build-script: fatal error: command terminated with a non-zero exit status 1, aborting
/build/src/swift/utils/build-script: fatal error: command terminated with a non-zero exit status 1, aborting
builder for '/nix/store/p7xv88dgqg7r6p3vf9bjbf7wnyra8pqh-swift-4.1.3.drv' failed with exit code 1
error: build of '/nix/store/p7xv88dgqg7r6p3vf9bjbf7wnyra8pqh-swift-4.1.3.drv' failed

@GrahamcOfBorg
Copy link

Timed out, unknown build status on x86_64-linux (full log)

Attempted: swift

Partial log (click to expand)

[1147/2690] Building CXX object lib/Target/X86/CMakeFiles/LLVMX86CodeGen.dir/X86WinAllocaExpander.cpp.o
[1148/2690] Building CXX object lib/Target/X86/InstPrinter/CMakeFiles/LLVMX86AsmPrinter.dir/X86IntelInstPrinter.cpp.o
[1149/2690] Building CXX object lib/Target/X86/InstPrinter/CMakeFiles/LLVMX86AsmPrinter.dir/X86ATTInstPrinter.cpp.o
[1150/2690] Building CXX object lib/Target/X86/CMakeFiles/LLVMX86CodeGen.dir/X86CallingConv.cpp.o
[1151/2690] Linking CXX static library lib/libLLVMX86CodeGen.a
[1152/2690] Building CXX object lib/Target/X86/MCTargetDesc/CMakeFiles/LLVMX86Desc.dir/X86AsmBackend.cpp.o
[1153/2690] Building CXX object lib/Target/X86/InstPrinter/CMakeFiles/LLVMX86AsmPrinter.dir/X86InstComments.cpp.o
[1154/2690] Linking CXX static library lib/libLLVMX86AsmPrinter.a
building of '/nix/store/59090whd1w0w74cf4qlam2pj8ksmvqaq-swift-4.1.3.drv' timed out after 3600 seconds
error: build of '/nix/store/59090whd1w0w74cf4qlam2pj8ksmvqaq-swift-4.1.3.drv' failed

@xeji
Copy link
Contributor

xeji commented Aug 30, 2018

Never built on aarch64: https://hydra.nixos.org/job/nixpkgs/trunk/swift.aarch64-linux/all, so I suggest to restrict it to x86_64-linux.

Mic92
Mic92 approved these changes Sep 3, 2018
View reviewed changes
Copy link
Member

@Mic92 Mic92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Swift itself works for me!

@xeji xeji merged commit e4f4deb into NixOS:master Sep 3, 2018
@xeji
Copy link
Contributor

xeji commented Sep 3, 2018

marked broken on aarch64 in e7a82ca

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dtzWill @GrahamcOfBorg @xeji @Mic92