Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gnome cleanup #45627

Merged
merged 6 commits into from Aug 25, 2018
Merged

Gnome cleanup #45627

merged 6 commits into from Aug 25, 2018

Conversation

jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Aug 25, 2018 •
edited

Motivation for this change

Mostly removing dbus-glib and libgnome-keyring where not used any more.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg GrahamcOfBorg added 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: xfce The Xfce Desktop Environment 10.rebuild-darwin: 1-10 10.rebuild-linux: 501+ labels Aug 25, 2018
@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: gnome3.gnome-desktop, gnome3.gnome-keyring, modemmanager, pan, umockdev, xfce.xfce4-settings

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: gnome3.gnome-desktop, gnome3.gnome-keyring, modemmanager, pan, umockdev, xfce.xfce4-settings

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/hzgyxxnqkghjfindlmir7pcxbk9sll16-umockdev-0.11.3-doc
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/hzgyxxnqkghjfindlmir7pcxbk9sll16-umockdev-0.11.3-doc
checking for references to /build in /nix/store/hzgyxxnqkghjfindlmir7pcxbk9sll16-umockdev-0.11.3-doc...
/nix/store/sd9l3dgzv1i7czymjyfiqilxq4g267y6-gnome-desktop-3.28.2
/nix/store/wj4pc49p87i7f3liqp1sp6m6khf5ijd9-gnome-keyring-3.28.2
/nix/store/s1n3pmdjnwjz2xxxf25v9pvhgl5062c1-modem-manager-1.7.990
/nix/store/p2sa2hlwf2kdlb5x1w1vfwaf9hhs4241-pan-0.145
/nix/store/ab49c0df3g6846qr7zlkv2i7pifvkl4x-umockdev-0.11.3-bin
/nix/store/b10bcrxnhazgxhc5viyw3qk2jnjxjr58-xfce4-settings-4.12.1

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: gnome3.gnome-desktop, gnome3.gnome-keyring, modemmanager, pan, umockdev, xfce.xfce4-settings

Partial log (click to expand)

stripping (with command strip and flags -S) in /nix/store/rsxb6z2nsgjk1cmn4490bimlq80r9fbv-gnome-keyring-3.28.2/lib  /nix/store/rsxb6z2nsgjk1cmn4490bimlq80r9fbv-gnome-keyring-3.28.2/bin
patching script interpreter paths in /nix/store/rsxb6z2nsgjk1cmn4490bimlq80r9fbv-gnome-keyring-3.28.2
checking for references to /build in /nix/store/rsxb6z2nsgjk1cmn4490bimlq80r9fbv-gnome-keyring-3.28.2...
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
/nix/store/3sj5l0ly8cjwxivijv01j8jrklr700la-gnome-desktop-3.28.2
/nix/store/rsxb6z2nsgjk1cmn4490bimlq80r9fbv-gnome-keyring-3.28.2
/nix/store/3c3lc1vcp0jmp2hj5i9qgaw5p362k9vm-modem-manager-1.7.990
/nix/store/ykgx9hwpf4lr4lywdd8mxkcva9nhazak-pan-0.145
/nix/store/0m11px8yiy1aiw9i4x6ibqx66lmmb6d3-umockdev-0.11.3-bin
/nix/store/sxyjbc9ad3r1xy7zbpf72n4hdm1zsxjd-xfce4-settings-4.12.1

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: gnome3.gnome-desktop, gnome3.gnome-keyring, modemmanager, pan, xfce.xfce4-settings

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: gnome3.gnome-desktop, gnome3.gnome-keyring, modemmanager, pan, xfce.xfce4-settings

Partial log (click to expand)

/nix/store/3sj5l0ly8cjwxivijv01j8jrklr700la-gnome-desktop-3.28.2
/nix/store/rsxb6z2nsgjk1cmn4490bimlq80r9fbv-gnome-keyring-3.28.2
/nix/store/3c3lc1vcp0jmp2hj5i9qgaw5p362k9vm-modem-manager-1.7.990
/nix/store/ykgx9hwpf4lr4lywdd8mxkcva9nhazak-pan-0.145
/nix/store/sxyjbc9ad3r1xy7zbpf72n4hdm1zsxjd-xfce4-settings-4.12.1

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: gnome3.gnome-desktop, gnome3.gnome-keyring, modemmanager, pan, xfce.xfce4-settings

Partial log (click to expand)

gzipping man pages under /nix/store/p2sa2hlwf2kdlb5x1w1vfwaf9hhs4241-pan-0.145/share/man/
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/p2sa2hlwf2kdlb5x1w1vfwaf9hhs4241-pan-0.145/bin
patching script interpreter paths in /nix/store/p2sa2hlwf2kdlb5x1w1vfwaf9hhs4241-pan-0.145
checking for references to /build in /nix/store/p2sa2hlwf2kdlb5x1w1vfwaf9hhs4241-pan-0.145...
/nix/store/sd9l3dgzv1i7czymjyfiqilxq4g267y6-gnome-desktop-3.28.2
/nix/store/wj4pc49p87i7f3liqp1sp6m6khf5ijd9-gnome-keyring-3.28.2
/nix/store/s1n3pmdjnwjz2xxxf25v9pvhgl5062c1-modem-manager-1.7.990
/nix/store/p2sa2hlwf2kdlb5x1w1vfwaf9hhs4241-pan-0.145
/nix/store/b10bcrxnhazgxhc5viyw3qk2jnjxjr58-xfce4-settings-4.12.1

@jtojnar jtojnar changed the base branch from master to staging August 25, 2018 19:40
@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: gnome3.gnome-desktop, gnome3.gnome-keyring, modemmanager, pan, umockdev, xfce.xfce4-settings

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: gnome3.gnome-desktop, gnome3.gnome-keyring, modemmanager, pan, umockdev, xfce.xfce4-settings

Partial log (click to expand)

shrinking /nix/store/lrj845m16v5pzpws5vhf461i11bwlcbi-xfce4-settings-4.12.1/bin/xfce4-keyboard-settings
shrinking /nix/store/lrj845m16v5pzpws5vhf461i11bwlcbi-xfce4-settings-4.12.1/bin/xfce4-appearance-settings
shrinking /nix/store/lrj845m16v5pzpws5vhf461i11bwlcbi-xfce4-settings-4.12.1/bin/xfsettingsd
shrinking /nix/store/lrj845m16v5pzpws5vhf461i11bwlcbi-xfce4-settings-4.12.1/bin/xfce4-mouse-settings
shrinking /nix/store/lrj845m16v5pzpws5vhf461i11bwlcbi-xfce4-settings-4.12.1/bin/xfce4-settings-manager
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/lrj845m16v5pzpws5vhf461i11bwlcbi-xfce4-settings-4.12.1/lib  /nix/store/lrj845m16v5pzpws5vhf461i11bwlcbi-xfce4-settings-4.12.1/bin
patching script interpreter paths in /nix/store/lrj845m16v5pzpws5vhf461i11bwlcbi-xfce4-settings-4.12.1
/nix/store/lrj845m16v5pzpws5vhf461i11bwlcbi-xfce4-settings-4.12.1/lib/xfce4/settings/appearance-install-theme: interpreter directive changed from "/bin/sh" to "/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/lrj845m16v5pzpws5vhf461i11bwlcbi-xfce4-settings-4.12.1...

@jtojnar jtojnar merged commit e8a6d22 into NixOS:staging Aug 25, 2018
@jtojnar jtojnar deleted the gnome-cleanup branch August 25, 2018 20:14
@GrahamcOfBorg
Copy link

Timed out, unknown build status on aarch64-linux (full log)

Attempted: gnome3.gnome-desktop, gnome3.gnome-keyring, modemmanager, pan, umockdev, xfce.xfce4-settings

Partial log (click to expand)

checking for references to /build in /nix/store/nkc7z5s1dqb1d7vfw5mxywrah6sfbqdl-libsecret-0.18.5...
shrinking RPATHs of ELF executables and libraries in /nix/store/lgb8cqr51kv381qw5hg41194qiz7q67a-libsecret-0.18.5-dev
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/lgb8cqr51kv381qw5hg41194qiz7q67a-libsecret-0.18.5-dev/lib
patching script interpreter paths in /nix/store/lgb8cqr51kv381qw5hg41194qiz7q67a-libsecret-0.18.5-dev
checking for references to /build in /nix/store/lgb8cqr51kv381qw5hg41194qiz7q67a-libsecret-0.18.5-dev...
cannot build derivation '/nix/store/6i5897xw23na9sw6xwnbdzvkgvh69l46-pinentry-1.1.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/zmf6qnjnigr1s6lkjjkdfqz7ma2wsr7r-gnupg-2.2.9.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/d3vq76dhd50bi18vsfv2faykrz9fd5x1-pan-0.145.drv': 5 dependencies couldn't be built
error: build of '/nix/store/2x9lj3vv963254cz0y9q4zd0wsziibv7-modem-manager-1.7.990.drv', '/nix/store/4cwwmd6dqrwp0sk8z2l6zx9702d7jhiq-gnome-keyring-3.28.2.drv', '/nix/store/d3vq76dhd50bi18vsfv2faykrz9fd5x1-pan-0.145.drv', '/nix/store/s1rph83i4bp50jbx6ar6wkxcaj6q8vys-gnome-desktop-3.28.2.drv', '/nix/store/zkrf58hc8p1f95jy68sxnmxgap1dzdfy-xfce4-settings-4.12.1.drv' failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: xfce The Xfce Desktop Environment 10.rebuild-darwin: 1-10 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jtojnar @GrahamcOfBorg