Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ibtool: impure-symlink-style Darwin package #45634

Closed
wants to merge 1 commit into from
Closed

ibtool: impure-symlink-style Darwin package #45634

wants to merge 1 commit into from

Conversation

TravisWhitaker
Copy link
Contributor

Motivation for this change

Adding an impure derivation for ibtool. My current motivation for doing this is packaging MoltenVK.

There are a few other impure Darwin derivations that work by making symlinks to system libraries/tools, but I'm sure I've broken some convention or something here. @copumpkin, I'm curious about the right way to do this.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@matthewbauer
Copy link
Member

👎 on this. Ibtool doesn't come with macOS by default - you need to install xcode for this to work.

If you really need ibtool for a project, you can use ${darwin.xcode}/Contents/Developer/usr/bin/ibtool.

@TravisWhitaker
Copy link
Contributor Author

Ah, thanks, I’ll give that a go. That could obviate the need for this.

@copumpkin
Copy link
Member

Agree with @matthewbauer. If the "pure" one works, that'd make me happier than this. The only other idea I have around ibtool (which I think we all really want in some form or other) is something like https://github.com/davidquesada/ibtool or hacking at https://github.com/Microsoft/WinObjC, neither of which are super good fits.

@matthewbauer
Copy link
Member

Closing for now. Feel free to reopen if you think this is still relevant.

@wegank wegank mentioned this pull request Jan 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@TravisWhitaker @matthewbauer @copumpkin @GrahamcOfBorg