Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/tests/networking: fix routes and virtual tests #45649

Merged
merged 2 commits into from Aug 26, 2018
Merged

nixos/tests/networking: fix routes and virtual tests #45649

merged 2 commits into from Aug 26, 2018

Conversation

xeji
Copy link
Contributor

@xeji xeji commented Aug 26, 2018

Motivation for this change

The "routes" and "virtual" networking tests have failed on hydra for quite some time because the output of ip route has changed. FIxed by modifying the expected outputs coded in the tests.

Hydra failures:

https://hydra.nixos.org/job/nixos/trunk-combined/nixos.tests.networking.networkd.routes.x86_64-linux
https://hydra.nixos.org/job/nixos/trunk-combined/nixos.tests.networking.networkd.virtual.x86_64-linux
https://hydra.nixos.org/job/nixos/trunk-combined/nixos.tests.networking.scripted.routes.x86_64-linux
https://hydra.nixos.org/job/nixos/trunk-combined/nixos.tests.networking.scripted.virtual.x86_64-linux

Things done
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)

cc #40257

@xeji
nixos/tests/networking: fix routes tests
f021702 
The output format of `ip route` changed, it now explicitly
shows "proto static" for static routes.
@xeji
nixos/tests/networking: fix "virtual" tests
3f8756c 
`ip route` now displays extended tun attributes, so the expected
output of this test changed.

Upstream change: https://git.kernel.org/pub/scm/network/iproute2/iproute2.git/commit/?id=118eda77d6602616bc523a17ee45171e879d1818
@grahamc
Copy link
Member

grahamc commented Aug 26, 2018

@GrahamcOfBorg test networking.scripted.routes
@GrahamcOfBorg test networking.networkd.routes
@GrahamcOfBorg test networking.scripted.virtual
@GrahamcOfBorg test networking.networkd.virtual

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: tests.networking.networkd.routes

Partial log (click to expand)

collecting coverage data
machine: running command: test -e /sys/kernel/debug/gcov
machine: exit status 1
syncing
machine: running command: sync
machine: exit status 0
test script finished in 20.55s
cleaning up
killing machine (pid 630)
/nix/store/1yn1cijhqhc9gg22dq08daijwsdzly4s-vm-test-run-routes-Networking-Networkd

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: tests.networking.networkd.virtual

Partial log (click to expand)

machine: exit status 1
syncing
machine: running command: sync
machine: exit status 0
test script finished in 21.35s
cleaning up
killing machine (pid 631)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/b0dg7p4qkwccm6p5mqw7621cs21j2f65-vm-test-run-Virtual-Networking-Networkd

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: tests.networking.scripted.routes

Partial log (click to expand)

collecting coverage data
machine: running command: test -e /sys/kernel/debug/gcov
machine: exit status 1
syncing
machine: running command: sync
machine: exit status 0
test script finished in 19.95s
cleaning up
killing machine (pid 630)
/nix/store/34pf0y43dab1mcxs6kbxqbjhqckh8dqs-vm-test-run-routes-Networking-Scripted

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: tests.networking.scripted.virtual

Partial log (click to expand)

machine: exit status 1
syncing
machine: running command: sync
machine: exit status 0
test script finished in 21.02s
cleaning up
killing machine (pid 631)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/is62na9wk4sa5bb4gwzxvac5ibhvp1zf-vm-test-run-Virtual-Networking-Scripted

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: tests.networking.scripted.routes

Partial log (click to expand)

collecting coverage data
machine: running command: test -e /sys/kernel/debug/gcov
machine: exit status 1
syncing
machine: running command: sync
machine: exit status 0
test script finished in 17.37s
cleaning up
killing machine (pid 596)
/nix/store/86q80cvx464d2d7inacvy92351ga82xa-vm-test-run-routes-Networking-Scripted

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: tests.networking.scripted.virtual

Partial log (click to expand)

syncing
machine: running command: sync
machine# [   17.129383] systemd[1]: Stopped Link configuration of tap0.
machine: exit status 0
test script finished in 19.29s
cleaning up
killing machine (pid 597)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/3qjgmqn1hyhk4y1y7vzpzhain9a5spms-vm-test-run-Virtual-Networking-Scripted

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: tests.networking.networkd.routes

Partial log (click to expand)

collecting coverage data
machine: running command: test -e /sys/kernel/debug/gcov
machine: exit status 1
syncing
machine: running command: sync
machine: exit status 0
test script finished in 126.55s
cleaning up
killing machine (pid 599)
/nix/store/m87m9lllklh5yc994aag0wysnkghg0zm-vm-test-run-routes-Networking-Networkd

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: tests.networking.networkd.virtual

Partial log (click to expand)

machine: exit status 1
syncing
machine: running command: sync
machine: exit status 0
test script finished in 19.30s
cleaning up
killing machine (pid 597)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/6p25bg0rw7pyzjcy7s81xj19ya3w9r5c-vm-test-run-Virtual-Networking-Networkd

@Mic92 Mic92 merged commit b1aa9cb into NixOS:master Aug 26, 2018
@xeji xeji deleted the p/networking-tests branch August 26, 2018 12:52
@xeji xeji mentioned this pull request Sep 18, 2018
Closed
41 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@xeji @grahamc @GrahamcOfBorg @Mic92