Fixes channel going back in time due to incomplete change. #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The change in d3d33d5 changed how the locally saved channel information was saved on the local machine. * NixOS@d3d33d5#diff-682bf482f6dd273f1c3c49afd99b4660R192 The changeset did *not* change the guard clause, which now made it act like this: 1. Try readlink on the file 2. (bail as it's undefined) The new behaviour is as more or less expected: 1. Reads the file if available 2. Split the URL components 3. Keep the last bit This can give us an empty string, which will compare to `-1` thus fulfilling the need.
|
Hmm, right now we offer |
|
By kicking Hydra I managed |
|
Same is happening with 18.03. It bounced back to 20th of September. No renaming was done there as far as I can tell. |
|
Could be this change wasn't deployed yet :) |
|
@edolstra: is it easy to check whether this has been deployed? (Or at least try re-deploy blindly, but it would be nice to know if this PR didn't help.) |
|
Looks like it's not deployed... |
|
Now it is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change in d3d33d5 changed how the
locally saved channel information was saved on the local machine.
The changeset did not change the guard clause, which now made it act
like this:
The new behaviour is as more or less expected:
This can give us an empty string, which will compare to
-1thusfulfilling the need.
I'd like to add these big disclaimers:
The code was as thoroughly tested as possible through this naïve script, which mostly replicates whatever is required.
This file is a giant hack :).