dex: 0.7 -> 0.8.0 #45639
Merged
dex: 0.7 -> 0.8.0 #45639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xeji
reviewed
Aug 26, 2018
pkgs/tools/X11/dex/default.nix
Outdated
| @@ -1,18 +1,19 @@ | |||
| { stdenv, fetchFromGitHub, python3 }: | |||
| { stdenv, fetchFromGitHub, python3, sphinx }: | |||
There was a problem hiding this comment.
no need to add sphinx here, you can reference it as python3.pkgs.sphinx, so the argument python3 is enough.
There was a problem hiding this comment.
Ah, I just copied it because I saw some other packages doing it that way, but fixed now.
pkgs/tools/X11/dex/default.nix
Outdated
| }; | ||
|
|
||
| propagatedBuildInputs = [ python3 ]; | ||
| nativeBuildInputs = [ sphinx ]; |
pkgs/top-level/all-packages.nix
Outdated
| @@ -2063,7 +2063,9 @@ with pkgs; | |||
| gtk = gtk3; | |||
| }; | |||
|
|
|||
| dex = callPackage ../tools/X11/dex { }; | |||
| dex = callPackage ../tools/X11/dex { | |||
| sphinx = python3Packages.sphinx; | |||
There was a problem hiding this comment.
This is not necessary, see comments above.
Signed-off-by: Johannes Löthberg <johannes@kyriasis.com>
|
@GrahamcOfBorg build dex |
|
Success on x86_64-linux (full log) Attempted: dex Partial log (click to expand)
|
|
No attempt on x86_64-darwin (full log) The following builds were skipped because they don't evaluate on x86_64-darwin: dex Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: dex Partial log (click to expand)
|
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Upstream update
Things done
nix-shell -p nox --run "nox-review wip"./result/bin/)