Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

thonny: init at 3.0.0b3 #45632

Merged
merged 1 commit into from Sep 10, 2018
Merged

thonny: init at 3.0.0b3 #45632

merged 1 commit into from Sep 10, 2018

Conversation

leenaars
Copy link
Contributor

Motivation for this change

Good Python IDE for beginners.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

ryantm
ryantm requested changes Aug 31, 2018
View reviewed changes
pkgs/applications/editors/thonny/default.nix Outdated

buildPythonApplication rec {
pname = "thonny";
name = "${pname}-${version}";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line can be deleted.

pkgs/applications/editors/thonny/default.nix
@@ -0,0 +1,46 @@
{ stdenv, fetchFromBitbucket, python3 }:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the author of this package specify python3 only? If not, can you please make it generic in the python version? The specific version can be specified in top-level/all-packages.nix

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The homepage states that it 'comes with Python 3", I could not find any reference of support for Python 2 in the documentation or anywhere else.

pkgs/applications/editors/thonny/default.nix Outdated
src = fetchFromBitbucket {
owner = "plas";
repo = pname;
#rev = version;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove comment.

pkgs/applications/editors/thonny/default.nix Outdated
sha256 = "1s3pp97r6p3j81idglnml4faxryk7saszxmv3gys1agdfj75qczr";
};

propagatedBuildInputs = with python3.pkgs; [ jedi pyserial tkinter
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The formatting of this line is not like how these lists are typically formatted in nixpkgs.

@ryantm
Copy link
Member

ryantm commented Sep 4, 2018

@GrahamcOfBorg build thonny

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: thonny

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: thonny

Partial log (click to expand)

Installing collected packages: thonny
Successfully installed thonny-3.0.0b3
/build/source
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/2l2v27bcq4f9a0h0sffnwkxl8facdd0g-thonny-3.0.0b3
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/2l2v27bcq4f9a0h0sffnwkxl8facdd0g-thonny-3.0.0b3/lib  /nix/store/2l2v27bcq4f9a0h0sffnwkxl8facdd0g-thonny-3.0.0b3/bin
patching script interpreter paths in /nix/store/2l2v27bcq4f9a0h0sffnwkxl8facdd0g-thonny-3.0.0b3
checking for references to /build in /nix/store/2l2v27bcq4f9a0h0sffnwkxl8facdd0g-thonny-3.0.0b3...
wrapping `/nix/store/2l2v27bcq4f9a0h0sffnwkxl8facdd0g-thonny-3.0.0b3/bin/.thonny-wrapped'...

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: thonny

Partial log (click to expand)

Successfully installed thonny-3.0.0b3
/build/source
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/g6af0dwpp3h35d6h1wpvl3rpr96szgqi-thonny-3.0.0b3
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/g6af0dwpp3h35d6h1wpvl3rpr96szgqi-thonny-3.0.0b3/lib  /nix/store/g6af0dwpp3h35d6h1wpvl3rpr96szgqi-thonny-3.0.0b3/bin
patching script interpreter paths in /nix/store/g6af0dwpp3h35d6h1wpvl3rpr96szgqi-thonny-3.0.0b3
checking for references to /build in /nix/store/g6af0dwpp3h35d6h1wpvl3rpr96szgqi-thonny-3.0.0b3...
wrapping `/nix/store/g6af0dwpp3h35d6h1wpvl3rpr96szgqi-thonny-3.0.0b3/bin/.thonny-wrapped'...
/nix/store/g6af0dwpp3h35d6h1wpvl3rpr96szgqi-thonny-3.0.0b3

@matthewbauer matthewbauer merged commit a03f07e into NixOS:master Sep 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryantm ryantm ryantm approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@leenaars @ryantm @GrahamcOfBorg @matthewbauer