Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mesa: enable texture floats #45631

Merged
merged 1 commit into from Aug 25, 2018
Merged

mesa: enable texture floats #45631

merged 1 commit into from Aug 25, 2018

Conversation

gebner
Copy link
Member

@gebner gebner commented Aug 25, 2018

Motivation for this change

Enable texture floats in mesa.

Texture floats were accidentally disabled by #43378. The current mesa version still requires the --enable-texture-float configure option.

Missing texture floats break for example alacritty: w/o texture floats, mesa only supports OpenGL 2.1 (see glxinfo output).

cc @vcunat @Anton-Latukha

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@vcunat
Copy link
Member

vcunat commented Aug 25, 2018

That's strange. I'm confident I've read upstream claiming to compile them in by default.

@vcunat
Copy link
Member

vcunat commented Aug 25, 2018

Hmm, I read that about texture compression only, apparently, not about texture floats (which also expired recently). Sounds OK to me.

@gebner gebner merged commit 0406721 into NixOS:staging Aug 25, 2018
@gebner
Copy link
Member Author

gebner commented Aug 25, 2018

Mesa indeed compiles texture floats by default now: here's the commit. But this commit is only in the master branch, and not in the 18.1.* releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gebner @vcunat @GrahamcOfBorg