Add human readable closure sizes to nix path-info #2373
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhipple
force-pushed
the
feature/human-readable-closure-sizes
branch
from
cc3654a
to
09f9cec
Compare
|
Default behavior unchanged, both to maintain compatibility and to be consistent with default unix utility behavior: And with the new option (human sorted to boot!): |
Unfortunately, -h is already taken as a short option by --help, so we have to use a different letter or the capitalized version. Resolves NixOS#2363
bhipple
force-pushed
the
feature/human-readable-closure-sizes
branch
from
09f9cec
to
2669fee
Compare
|
Is there an easy way to get the |
edolstra
reviewed
Aug 26, 2018
src/nix/path-info.cc
Outdated
| ++power; | ||
| res /= 1024; | ||
| } | ||
| std::cout << '\t' << std::setw(11) << std::setprecision(3) << res << idents[power]; |
There was a problem hiding this comment.
Don't use iostream manipulators, they're stateful and ugly. Boost format strings are much nicer (e.g. std::cout << fmt("%.3f", ...) or something like that.
idents[power] looks like it could overflow in theory.
There was a problem hiding this comment.
Indeed, updated to be future proof in a > 1024 yottabyte world, and swapped to boost::format 👍
If the user has an object greater than 1024 yottabytes, it'll just display it as N yottabytes instead of overflowing. Swaps to use boost::format strings instead of std::setw and std::setprecision.
|
Closer inspection of The |
|
If there are any further suggestions I'm happy to update; otherwise I think this should be good to go as-is. |
|
Thanks, merged! |
|
If we wanted to be "overly" correct, we would show EDIT: thanks for the PR, BTW. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately, -h is already taken as a short option by --help, so we have to
use a different letter or the capitalized version.
Resolves #2363