nixos/switch-to-configuration: support shells which aren't POSIX compliant #45945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…liant `fish' doesn't support the `ENVVAR=foo my cmd' notation which breaks `nixos-rebuild switch': ``` fish: Unsupported use of '='. To run '/nix/store/dzn7zyf1dhxlvrbpgn yn7di58zvfblrq-systemd-239/bin/systemctl' with a modified environment, please use 'env XDG_RUNTIME_DIR=/run/user/1000 /nix/store/dzn7zyf1dhxlvrbpgnyn7di58zvfblrq-systemd-239/bin/systemctl…' ``` The issue can be solved by adding an `export' statement and run the command after that. Fixes NixOS#45897
|
Duplicate of #45932 |
|
This would still not solve it in case of say |
|
Maybe |
|
closing as duplicate, let's fix this properly in #45932 ... |
Ma27
added a commit
to Ma27/nixpkgs
that referenced
this pull request
Sep 4, 2018
This fixes an issue with shells like fish that are not fully POSIX compliant. The syntax `ENV=val cmd' doesn't work properly in there. This issue has been addressed in NixOS#45932 and NixOS#45945, however it has been recommended to use a single shell (`stdenv.shell' which is either `bash' or `sh') to significantly reduce the maintenance overload in the future. See NixOS#45897 (comment) Fixes NixOS#45897 /cc @FRidh @xaverdh @etu
9 tasks
xeji
pushed a commit
that referenced
this pull request
Sep 5, 2018
This fixes an issue with shells like fish that are not fully POSIX compliant. The syntax `ENV=val cmd' doesn't work properly in there. This issue has been addressed in #45932 and #45945, however it has been recommended to use a single shell (`stdenv.shell' which is either `bash' or `sh') to significantly reduce the maintenance overload in the future. See #45897 (comment) Fixes #45897 /cc @FRidh @xaverdh @etu (cherry picked from commit df05618)
xeji
pushed a commit
that referenced
this pull request
Sep 5, 2018
This fixes an issue with shells like fish that are not fully POSIX compliant. The syntax `ENV=val cmd' doesn't work properly in there. This issue has been addressed in #45932 and #45945, however it has been recommended to use a single shell (`stdenv.shell' which is either `bash' or `sh') to significantly reduce the maintenance overload in the future. See #45897 (comment) Fixes #45897 /cc @FRidh @xaverdh @etu
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fish' doesn't support theENVVAR=foo my cmd' notation which breaks`nixos-rebuild switch':
The issue can be solved by adding an `export' statement and run the
command after that.
Fixes #45897
Motivation for this change
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)