Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use global configs for Castor 1 #1920

Merged
merged 3 commits into from
Sep 23, 2018
Merged

Conversation

Tidal-Stream
Copy link
Contributor

This unifies all Castor 1 variants to use the global configs. It also moves the mass, max temperature, and solid fuel to the global config, so individual configs have to provide just the model.

@PhineasFreak
Copy link
Contributor

Two requests:

  • Remove the mass parameter since it breaks some global engine config calculations (not really applicable for SRMs but just to be on the same page).
  • Reduce the maximum temperature to something saner, like 773.15 K (500 °C). 1800 K (1526 °C) is far too high for a rocket motor.

@Tidal-Stream
Copy link
Contributor Author

  • I will remove the mass although SRMs having fuel are already different than liquid engines.
  • I picked the temperature from RealFuels since it seemed to be the most up-to-date config (took the fuel type and load from there as well). I will change it and check if it overheats. I assume this is external and not internal temperature because in one of my tests of Procedural solid rocket motors they were at over 3,000 K.

@raidernick
Copy link
Contributor

do a += description on my part to leave in the directions about how to radially place these and to remove the fins as this is important for proper use with my rocket parts.

* Remove the mass parameter since it breaks some global engine config calculations.

* Reduce the maximum temperature to something saner - 773.15 K (500 °C) and 873.15 K skin temperature (600 °C). 1800 K (1526 °C) is far too high for a rocket motor.

* Do a += description on the RaiderNick US Rockets part to leave in the directions about how to radially place these and to remove the fins as this is important for proper use with his rocket parts.
@Tidal-Stream
Copy link
Contributor Author

Tidal-Stream commented Sep 19, 2018

I fixed the issues pointed out. I am sorry for the two commits, I erroneously pushed the first before proper testing. When you merge the pull request, use the squash option and leave their descriptions out.
screenshot33

@raidernick raidernick merged commit 7a010a0 into KSP-RO:master Sep 23, 2018
@raidernick
Copy link
Contributor

I'll fix this stuff on my end for my parts make a new pr for the others

@Tidal-Stream Tidal-Stream deleted the fasa-srb branch September 24, 2018 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants