New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
uefitool: init at 0.25.1 #45963
uefitool: init at 0.25.1 #45963
Conversation
Success on x86_64-linux (full log) Attempted: uefitool Partial log (click to expand)
|
Success on aarch64-linux (full log) Attempted: uefitool Partial log (click to expand)
|
let's check the darwin build |
Success on aarch64-linux (full log) Attempted: uefitool Partial log (click to expand)
|
Success on x86_64-linux (full log) Attempted: uefitool Partial log (click to expand)
|
Failure on x86_64-darwin (full log) Attempted: uefitool Partial log (click to expand)
|
looks like this is not intended for darwin. Please change platforms to |
name = "UEFITool-${version}"; | ||
version = "0.25.1"; | ||
|
||
src = fetchurl { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be a fetchzip
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
… wait, why? it's a download for a .tar.gz
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fetchzip
is for any archive, not just ZIP. GitHub may (and sometimes does) recompress revision archives, so this will break unless we checksum contents rather than archive itself.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In exchange it adds an unneeded dependency to zip
… right?
Regardless, I think this should be fetchFromGitHub
:)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fetchFromGitHub
is just a fancy fetchzip
wrapper: https://github.com/NixOS/nixpkgs/blob/master/pkgs/top-level/all-packages.nix#L248
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. Doesn't mean it's not semantically the correct one, esp. when downloading a .tar.gz
:)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's controversial and still up to debate. I actually prefer fetchTarball
/fetchzip
style interface over fetchFromGitHub
. I agree fetchzip
should be renamed.
(triage) @tadfisher, are you still interested in moving this forward? |
@Ekleog I am, but I don't have a Mac to test with. This should compile for darwin, but I don't know how to make that work without hardware to test on. Should I mark this Linux-only or just broken on darwin? |
Please mark it broken on darwin: darwin is supported upstream (they distribute Mac binaries) but doesn't currently build in nixpkgs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Please mark it broken on darwin"
This can probably be closed, now that #57034 is merged. |
Motivation for this change
Add the UEFITool application for examining and modifying UEFI firmware images.
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)