Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bird: set reloadIfChanged to true #45924

Merged
merged 1 commit into from Sep 2, 2018
Merged

bird: set reloadIfChanged to true #45924

merged 1 commit into from Sep 2, 2018

Conversation

flokli
Copy link
Contributor

@flokli flokli commented Sep 2, 2018

This will trigger the reload instead of restart command if a definition
changes, which is much more desireable for a routing daemon.

Motivation for this change

Currently bird restarts every time its configuration is changed, causing bgp sessions to be re-established for example.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@flokli
bird: set reloadIfChanged to true
fe8ec40 
This will trigger the reload instead of restart command if a definition
changes, which is much more desireable for a routing daemon.
@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: bird

Partial log (click to expand)

these paths will be fetched (0.23 MiB download, 0.59 MiB unpacked):
  /nix/store/6c8d24cc8x0r1p61jh7y8988dl94ngr5-bird-1.6.3
copying path '/nix/store/6c8d24cc8x0r1p61jh7y8988dl94ngr5-bird-1.6.3' from 'https://nix-cache.s3.amazonaws.com'...
/nix/store/6c8d24cc8x0r1p61jh7y8988dl94ngr5-bird-1.6.3

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: bird

Partial log (click to expand)

these paths will be fetched (0.19 MiB download, 0.55 MiB unpacked):
  /nix/store/vl5ss3a0jsi3zvvp1fhpyy4jggj7f0xf-bird-1.6.3
copying path '/nix/store/vl5ss3a0jsi3zvvp1fhpyy4jggj7f0xf-bird-1.6.3' from 'https://cache.nixos.org'...
/nix/store/vl5ss3a0jsi3zvvp1fhpyy4jggj7f0xf-bird-1.6.3

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: bird

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@xeji xeji merged commit 953b77f into NixOS:master Sep 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@flokli @GrahamcOfBorg @xeji