Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/manual: nixos-help knows about colon-separated BROWSER #45911

Merged
merged 1 commit into from Sep 2, 2018
Merged

nixos/manual: nixos-help knows about colon-separated BROWSER #45911

merged 1 commit into from Sep 2, 2018

Conversation

samueldr
Copy link
Member

@samueldr samueldr commented Sep 1, 2018

This is the semantics as understood by xdg-open. Using these semantics
on a non-colon-separated variable works because it acts as if it was a
one element long list.

This fixes an issue where it would try to exec
google-chrome-beta:google-chrome:chromium:firefox on a system
configured with these semantics in mind.

Motivation for this change
Things done
  • ✔️ Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • ✔️ NixOS
    • ⬜ macOS
    • ⬜ other Linux distributions
  • ⬜ Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • ⬜ Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • ✔️ Tested execution of all binary files (usually in ./result/bin/)
  • ⬜ Determined the impact on package closure size (by running nix path-info -S before and after)
  • ✔️ Fits CONTRIBUTING.md.

@samueldr
nixos/manual: nixos-help knows about colon-separated BROWSER
4ff5f30 
This is the semantics as understood by `xdg-open`. Using these semantics
on a non-colon-separated variable works because it acts as if it was a
one element long list.

This fixes an issue where it would try to exec
`google-chrome-beta:google-chrome:chromium:firefox` on a system
configured with these semantics in mind.
@grahamc
Copy link
Member

grahamc commented Sep 2, 2018 

[grahamc@Morbo:~]$ BROWSER=foo:bar:baz:firefox:google-chromestable

[grahamc@Morbo:~]$      browser="$(
>         IFS=: ; for b in $BROWSER; do
>           [ -n "$(type -P "$b" || true)" ] && echo "$b" && break
>         done
>       )"

[grahamc@Morbo:~]$ echo $browser
firefox

@grahamc grahamc merged commit 146f8ba into NixOS:master Sep 2, 2018
@samueldr
Copy link
Member Author

samueldr commented Sep 2, 2018

post-merge comment

While it seems wateful to run xdg-open if it's using the same semantics for $BROWSER, xdg-open does more than simply looking at $BROWSER.

@samueldr samueldr deleted the fix/nixos-help-browser branch September 2, 2018 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@samueldr @grahamc @GrahamcOfBorg