Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #45908
What was tested
The legacy boot using
qemu-system-i386 -m 1024 -cdrom result/iso/*.iso
, and also using the x86_64 variant of qemu.What was not tested
EFI; while the file is at the right location, I have no 32 bit efi, and copying the 32 bit efi file at the bootx64.efi location won't make this work. I do not know how to boot a 32 bit EFI with QEMU, and initial searches weren't good in finding options.
The risks of having a 32-bit only EFI boot is low enough, though, but it would be better to have it be tested.
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
) → the iso itselfnix path-info -S
before and after)cc @vcunat