Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

racket-minimal: fix hash #45952

Merged
merged 1 commit into from Sep 2, 2018
Merged

racket-minimal: fix hash #45952

merged 1 commit into from Sep 2, 2018

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Sep 2, 2018

Motivation for this change

#45650 updated Racket to 7.0 but missed to update racket-minimal hash

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@xeji
Copy link
Contributor

xeji commented Sep 2, 2018

@GrahamcOfBorg build racket-minimal

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: racket-minimal

Partial log (click to expand)

shrinking /nix/store/95k3gmkv77v03gkk0nch3y2f1byq6qnz-racket-minimal-7.0/lib/racket/gracket
shrinking /nix/store/95k3gmkv77v03gkk0nch3y2f1byq6qnz-racket-minimal-7.0/bin/.racket-wrapped
gzipping man pages under /nix/store/95k3gmkv77v03gkk0nch3y2f1byq6qnz-racket-minimal-7.0/share/man/
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/95k3gmkv77v03gkk0nch3y2f1byq6qnz-racket-minimal-7.0/lib  /nix/store/95k3gmkv77v03gkk0nch3y2f1byq6qnz-racket-minimal-7.0/bin
patching script interpreter paths in /nix/store/95k3gmkv77v03gkk0nch3y2f1byq6qnz-racket-minimal-7.0
/nix/store/95k3gmkv77v03gkk0nch3y2f1byq6qnz-racket-minimal-7.0/bin/.raco-wrapped: interpreter directive changed from "/bin/sh" to "/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/95k3gmkv77v03gkk0nch3y2f1byq6qnz-racket-minimal-7.0...
wrong ELF type
/nix/store/95k3gmkv77v03gkk0nch3y2f1byq6qnz-racket-minimal-7.0

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: racket-minimal

Partial log (click to expand)

make[2]: Leaving directory '/private/tmp/nix-build-racket-minimal-7.0.drv-0/racket-7.0/src/build'
make[1]: Leaving directory '/private/tmp/nix-build-racket-minimal-7.0.drv-0/racket-7.0/src/build'
glibPreFixupPhase
post-installation fixup
gzipping man pages under /nix/store/bqrq279dzvmjdgrybappjmbcgxmy20i8-racket-minimal-7.0/share/man/
strip is /nix/store/df6k4mgdjxciy0f637lryp7c9ln7n1m3-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/bqrq279dzvmjdgrybappjmbcgxmy20i8-racket-minimal-7.0/lib  /nix/store/bqrq279dzvmjdgrybappjmbcgxmy20i8-racket-minimal-7.0/bin
patching script interpreter paths in /nix/store/bqrq279dzvmjdgrybappjmbcgxmy20i8-racket-minimal-7.0
/nix/store/bqrq279dzvmjdgrybappjmbcgxmy20i8-racket-minimal-7.0/bin/.raco-wrapped: interpreter directive changed from "/bin/sh" to "/nix/store/cblfnvb5rmhd2z231mqasn0brzh1hhv4-bash-4.4-p23/bin/sh"
/nix/store/bqrq279dzvmjdgrybappjmbcgxmy20i8-racket-minimal-7.0

@xeji xeji merged commit a3872f6 into NixOS:master Sep 2, 2018
@marsam marsam deleted the feature/fix-racket-minimal-hash branch September 2, 2018 19:58
@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: racket-minimal

Partial log (click to expand)

shrinking /nix/store/lhkzwfrdwhjcq2mck85r0m642nh9whzf-racket-minimal-7.0/lib/racket/starter
shrinking /nix/store/lhkzwfrdwhjcq2mck85r0m642nh9whzf-racket-minimal-7.0/bin/.racket-wrapped
gzipping man pages under /nix/store/lhkzwfrdwhjcq2mck85r0m642nh9whzf-racket-minimal-7.0/share/man/
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/lhkzwfrdwhjcq2mck85r0m642nh9whzf-racket-minimal-7.0/lib  /nix/store/lhkzwfrdwhjcq2mck85r0m642nh9whzf-racket-minimal-7.0/bin
patching script interpreter paths in /nix/store/lhkzwfrdwhjcq2mck85r0m642nh9whzf-racket-minimal-7.0
/nix/store/lhkzwfrdwhjcq2mck85r0m642nh9whzf-racket-minimal-7.0/bin/.raco-wrapped: interpreter directive changed from "/bin/sh" to "/nix/store/fqm2x6kiay1q4vg7pqp4wp17bdijlyc3-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/lhkzwfrdwhjcq2mck85r0m642nh9whzf-racket-minimal-7.0...
wrong ELF type
/nix/store/lhkzwfrdwhjcq2mck85r0m642nh9whzf-racket-minimal-7.0

@clacke clacke mentioned this pull request Sep 9, 2018
Closed
vcunat added a commit that referenced this pull request Sep 9, 2018
@vcunat
racket: warn to avoid repeating #45952
d0413d1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@marsam @xeji @GrahamcOfBorg