Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kitty: Add terminfo attr #45953

Merged
merged 1 commit into from Sep 2, 2018
Merged

kitty: Add terminfo attr #45953

merged 1 commit into from Sep 2, 2018

Conversation

rvolosatovs
Copy link
Member

Motivation for this change

It is desireable to install only the TERMINFO of the package on headless systems, e.g. for ssh to work properly.
Adapted the solution from termite

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@xeji
Copy link
Contributor

xeji commented Sep 2, 2018

@GrahamcOfBorg build kitty

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: kitty

Partial log (click to expand)

strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/vx4g5iaik4cdahpq7ql1hrmxvndbhw7p-kitty-0.11.3/lib  /nix/store/vx4g5iaik4cdahpq7ql1hrmxvndbhw7p-kitty-0.11.3/bin
patching script interpreter paths in /nix/store/vx4g5iaik4cdahpq7ql1hrmxvndbhw7p-kitty-0.11.3
/nix/store/vx4g5iaik4cdahpq7ql1hrmxvndbhw7p-kitty-0.11.3/lib/kitty/kitty/launcher/kitty: interpreter directive changed from "/usr/bin/env python3" to "/nix/store/hy65mn4wjswqih75gfr6g4q3xgqdm325-python3-3.6.6/bin/python3"
checking for references to /build in /nix/store/vx4g5iaik4cdahpq7ql1hrmxvndbhw7p-kitty-0.11.3...
shrinking RPATHs of ELF executables and libraries in /nix/store/y1jd3g1137gaxc2yi0lbfvh8xsb1lp8l-kitty-0.11.3-terminfo
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/y1jd3g1137gaxc2yi0lbfvh8xsb1lp8l-kitty-0.11.3-terminfo
checking for references to /build in /nix/store/y1jd3g1137gaxc2yi0lbfvh8xsb1lp8l-kitty-0.11.3-terminfo...
/nix/store/vx4g5iaik4cdahpq7ql1hrmxvndbhw7p-kitty-0.11.3

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: kitty

Partial log (click to expand)

strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/8vajaq5xi69hawaaad788g5m2sdrai9s-kitty-0.11.3/lib  /nix/store/8vajaq5xi69hawaaad788g5m2sdrai9s-kitty-0.11.3/bin
patching script interpreter paths in /nix/store/8vajaq5xi69hawaaad788g5m2sdrai9s-kitty-0.11.3
/nix/store/8vajaq5xi69hawaaad788g5m2sdrai9s-kitty-0.11.3/lib/kitty/kitty/launcher/kitty: interpreter directive changed from "/usr/bin/env python3" to "/nix/store/sb88r9crdhinhkm6vpxwzf5zmij86p8v-python3-3.6.6/bin/python3"
checking for references to /build in /nix/store/8vajaq5xi69hawaaad788g5m2sdrai9s-kitty-0.11.3...
shrinking RPATHs of ELF executables and libraries in /nix/store/pjpa8vz67fak1izpn2gb2ab32wly7j8s-kitty-0.11.3-terminfo
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/pjpa8vz67fak1izpn2gb2ab32wly7j8s-kitty-0.11.3-terminfo
checking for references to /build in /nix/store/pjpa8vz67fak1izpn2gb2ab32wly7j8s-kitty-0.11.3-terminfo...
/nix/store/8vajaq5xi69hawaaad788g5m2sdrai9s-kitty-0.11.3

@xeji xeji merged commit 720c163 into NixOS:master Sep 2, 2018
@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: kitty

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@rvolosatovs rvolosatovs deleted the feature/kitty-terminfo branch September 3, 2018 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rvolosatovs @xeji @GrahamcOfBorg