nixos/switch-to-configuration: Fix reload of user units for users of fish shell #45932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fish shell Since fish doesn't allow environment variables to be set before a command by syntax one needs to use `env`. Using `env` works in both fish as well as bash and zsh.
9 tasks
|
Thanks a lot for fixing this, I'm sorry that my change broke your setup! |
|
@Ma27 That other solution is probably more universal, so I'll close this 👍 |
Ma27
added a commit
to Ma27/nixpkgs
that referenced
this pull request
Sep 4, 2018
This fixes an issue with shells like fish that are not fully POSIX compliant. The syntax `ENV=val cmd' doesn't work properly in there. This issue has been addressed in NixOS#45932 and NixOS#45945, however it has been recommended to use a single shell (`stdenv.shell' which is either `bash' or `sh') to significantly reduce the maintenance overload in the future. See NixOS#45897 (comment) Fixes NixOS#45897 /cc @FRidh @xaverdh @etu
9 tasks
xeji
pushed a commit
that referenced
this pull request
Sep 5, 2018
This fixes an issue with shells like fish that are not fully POSIX compliant. The syntax `ENV=val cmd' doesn't work properly in there. This issue has been addressed in #45932 and #45945, however it has been recommended to use a single shell (`stdenv.shell' which is either `bash' or `sh') to significantly reduce the maintenance overload in the future. See #45897 (comment) Fixes #45897 /cc @FRidh @xaverdh @etu (cherry picked from commit df05618)
xeji
pushed a commit
that referenced
this pull request
Sep 5, 2018
This fixes an issue with shells like fish that are not fully POSIX compliant. The syntax `ENV=val cmd' doesn't work properly in there. This issue has been addressed in #45932 and #45945, however it has been recommended to use a single shell (`stdenv.shell' which is either `bash' or `sh') to significantly reduce the maintenance overload in the future. See #45897 (comment) Fixes #45897 /cc @FRidh @xaverdh @etu
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Since fish doesn't allow environment variables to be set before a
command by syntax one needs to use
env. Usingenvworks in bothfish as well as bash and zsh.
My only concern with this is that we might want to do something like
@env@and replace it somewhere. If someone can point out where I'll change it.Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)cc @Ma27