Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

freedesktop modules: disable by default #45920

Closed
wants to merge 1 commit into from
Closed

freedesktop modules: disable by default #45920

wants to merge 1 commit into from

Conversation

michaelpj
Copy link
Contributor

Motivation for this change

In the spirit of not asking for things unless they're actually needed, this sets the options introduced in #45058 to false by default.

This should only affect headless systems, since they're set in xserver.nix. I think it's plausible that you don't need most of these on a headless system. Maybe some people use MIME info, but I wouldn't have thought so.

This should only be merged after the 18.09 branch off.

@jtojnar @samueldr

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@samueldr samueldr added this to the 19.03 milestone Sep 1, 2018
worldofpeace
worldofpeace approved these changes Sep 2, 2018
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like this makes sense especially in the spirit of not polluting headless systems.

@dezgeg
Copy link
Contributor

dezgeg commented Sep 2, 2018

Maybe they can be disabled by default but auto-enabled if the X server is enabled?

@matthewbauer
Copy link
Member

These only have effect when you add packages to systemPackages though. I think it’s safe to have it on by default IMO.

@michaelpj
Copy link
Contributor Author

Maybe they can be disabled by default but auto-enabled if the X server is enabled?

That's exactly the case - xserver.nix already (redundantly) enables them. Originally it was for clarity, now it will actually matter.

@jtojnar
Copy link
Contributor

jtojnar commented Sep 17, 2018

@teto Could you please explain the issues you see with this?

@teto
Copy link
Member

teto commented Sep 26, 2018

I am a supporter of the XDG spec that - has now outlived the X ecosystem since non X programs support it: ncmpcpp/neovim/khal/khard/... so I am kind of wary as to anything that makes it harder to use.
While disabling icons/menus might be straigthforward, I would keep mime as is.
I don't think autostart is abused on servers (systemd being better) so that should be safe to turn off too.

Also I had missed the part This should only affect headless systems, since they're set in xserver.nix which is nice (got baited by the title).

@michaelpj michaelpj mentioned this pull request Nov 17, 2018
Merged
9 tasks
@infinisil
Copy link
Member

@teto I'm not sure, I've never ever used mime stuff on a headless machine. I think we can set it to false for now. If people need it, they can set it to true themselves.

@jtojnar jtojnar mentioned this pull request Mar 21, 2019
Open
@matthewbauer matthewbauer removed this from the 19.03 milestone Apr 5, 2019
@mmahut
Copy link
Member

mmahut commented Aug 12, 2019

Any news on this?

@michaelpj
Copy link
Contributor Author

I still think we should do this. We now have some precedent in that xdg.portals.enable is set to false by default.

@worldofpeace
Copy link
Contributor

I still think we should do this. We now have some precedent in that xdg.portals.enable is set to false by default.

That's mostly because it's not quite there yet to being able to be used by everyone, and it brings in rather large dependencies.

@michaelpj
Copy link
Contributor Author

That's mostly because it's not quite there yet to being able to be used by everyone, and it brings in rather large dependencies.

Sure, but:

  • It's an important DE component - things will behave weirdly without it e.g. file chooser dialogs.
  • We decided we could live without it so long as the DE/xserver modules set it.

It's true that it's probably less annoying to unexpectedly have portal disabled than e.g. mime, though.

@stale
Copy link

stale bot commented Jun 1, 2020

Thank you for your contributions.
This has been automatically marked as stale because it has had no activity for 180 days.
If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.
Here are suggestions that might help resolve this more quickly:

  1. Search for maintainers and people that previously touched the
    related code and @ mention them in a comment.
  2. Ask on the NixOS Discourse. 3. Ask on the #nixos channel on
    irc.freenode.net.

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 1, 2020
@SuperSandro2000
Copy link
Member

Closing due to inactivity. Feel free to reopen the discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace approved these changes

Assignees
No one assigned
Labels
2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet