Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sc-controller: 0.4.3 -> 0.4.4 #45939

Merged
merged 3 commits into from Sep 2, 2018
Merged

sc-controller: 0.4.3 -> 0.4.4 #45939

merged 3 commits into from Sep 2, 2018

Conversation

rnhmjoj
Copy link
Contributor

@rnhmjoj rnhmjoj commented Sep 2, 2018 •
edited

Motivation for this change

Fix #45144

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s)
  • Tested compilation of all pkgs that depend on this change
  • Tested execution of all binary files
  • Determined the impact on package closure size (x1.9 increase)
  • Fits CONTRIBUTING.md.

I submitted to upstream this patch and it was confirmed to work on other systems as well as NixOS, it should be removed in the next release.

R. RyanTM and others added 2 commits August 16, 2018 12:53
@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: sc-controller

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@xeji xeji mentioned this pull request Sep 2, 2018
Closed
@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: sc-controller

Partial log (click to expand)

tests/test_parser/test_modifiers.py ...................                  [ 52%]
tests/test_parser/test_special_actions.py ............                   [ 60%]
tests/test_profile/test_actions.py ......................                [ 76%]
tests/test_profile/test_modeshift.py ..                                  [ 77%]
tests/test_profile/test_modifiers.py ..................                  [ 90%]
tests/test_profile/test_special_actions.py ............                  [ 99%]
tests/test_strings/test_modifiers.py .                                   [100%]

========================== 140 passed in 7.27 seconds ==========================
/nix/store/4ga9spwjpn0cqpmjwn35p39mz2a2s39x-sc-controller-0.4.4

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: sc-controller

Partial log (click to expand)

tests/test_parser/test_modifiers.py ...................                  [ 52%]
tests/test_parser/test_special_actions.py ............                   [ 60%]
tests/test_profile/test_actions.py ......................                [ 76%]
tests/test_profile/test_modeshift.py ..                                  [ 77%]
tests/test_profile/test_modifiers.py ..................                  [ 90%]
tests/test_profile/test_special_actions.py ............                  [ 99%]
tests/test_strings/test_modifiers.py .                                   [100%]

========================== 140 passed in 5.38 seconds ==========================
/nix/store/mh65ylri01d8m8rqb9gsd98469appjdr-sc-controller-0.4.4

xeji
xeji reviewed Sep 2, 2018
View reviewed changes
pkgs/misc/drivers/sc-controller/default.nix Outdated
@@ -24,12 +24,15 @@ buildPythonApplication rec {

checkInputs = [ pytest ];

patches = [ ./fix-udev.patch ];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a comment that references the upstream issue/patch and reminds to remove this on the next update.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: sc-controller

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: sc-controller

Partial log (click to expand)

/nix/store/4ga9spwjpn0cqpmjwn35p39mz2a2s39x-sc-controller-0.4.4

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: sc-controller

Partial log (click to expand)

/nix/store/mh65ylri01d8m8rqb9gsd98469appjdr-sc-controller-0.4.4

@xeji xeji merged commit 87ba30b into NixOS:master Sep 2, 2018
@rnhmjoj rnhmjoj deleted the scc branch February 23, 2019 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xeji xeji xeji left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rnhmjoj @GrahamcOfBorg @xeji