Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ocamlPackages.piqi{,-ocaml}: fix build with OCaml 4.06 #45481

Merged
merged 2 commits into from Aug 23, 2018
Merged

ocamlPackages.piqi{,-ocaml}: fix build with OCaml 4.06 #45481

merged 2 commits into from Aug 23, 2018

Conversation

vbgl
Copy link
Contributor

@vbgl vbgl commented Aug 22, 2018

Motivation for this change

Compatibility with OCaml 4.06.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@xeji
Copy link
Contributor

xeji commented Aug 23, 2018

@GrahamcOfBorg build ocamlPackages.piqi ocamlPackages.piqi-ocaml

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: ocamlPackages.piqi, ocamlPackages.piqi-ocaml

Partial log (click to expand)

Installation successful.
make[1]: Leaving directory '/private/tmp/nix-build-piqi-ocaml-0.7.5.drv-0/piqi-ocaml-0.7.5/piqirun'
install -d /nix/store/gsb75yirk81w5ldmjhkc2dhc35p8whjd-piqi-ocaml-0.7.5/bin
install piqic-ocaml/piqic-ocaml /nix/store/gsb75yirk81w5ldmjhkc2dhc35p8whjd-piqi-ocaml-0.7.5/bin
post-installation fixup
/nix/store/5im29qx9rni3w8l3j8i2yr22sin55kxv-cctools-binutils-darwin/bin/strip is /nix/store/5im29qx9rni3w8l3j8i2yr22sin55kxv-cctools-binutils-darwin/bin/strip
stripping (with command /nix/store/5im29qx9rni3w8l3j8i2yr22sin55kxv-cctools-binutils-darwin/bin/strip and flags -S) in /nix/store/gsb75yirk81w5ldmjhkc2dhc35p8whjd-piqi-ocaml-0.7.5/lib  /nix/store/gsb75yirk81w5ldmjhkc2dhc35p8whjd-piqi-ocaml-0.7.5/bin
patching script interpreter paths in /nix/store/gsb75yirk81w5ldmjhkc2dhc35p8whjd-piqi-ocaml-0.7.5
/nix/store/r3bcfynpp5fggb6szj546kqg180saqdb-piqi-0.6.13
/nix/store/gsb75yirk81w5ldmjhkc2dhc35p8whjd-piqi-ocaml-0.7.5

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: ocamlPackages.piqi, ocamlPackages.piqi-ocaml

Partial log (click to expand)

wrong ELF type
shrinking /nix/store/m52d5zmfl3g73yb4lg9wbw5yprrvhg0b-piqi-ocaml-0.7.5/bin/piqic-ocaml
/nix/store/vp40my263xk32f07788srrgl59rycsna-binutils-2.30/bin/strip is /nix/store/vp40my263xk32f07788srrgl59rycsna-binutils-2.30/bin/strip
stripping (with command /nix/store/vp40my263xk32f07788srrgl59rycsna-binutils-2.30/bin/strip and flags -S) in /nix/store/m52d5zmfl3g73yb4lg9wbw5yprrvhg0b-piqi-ocaml-0.7.5/lib  /nix/store/m52d5zmfl3g73yb4lg9wbw5yprrvhg0b-piqi-ocaml-0.7.5/bin
patching script interpreter paths in /nix/store/m52d5zmfl3g73yb4lg9wbw5yprrvhg0b-piqi-ocaml-0.7.5
checking for references to /build in /nix/store/m52d5zmfl3g73yb4lg9wbw5yprrvhg0b-piqi-ocaml-0.7.5...
wrong ELF type
wrong ELF type
/nix/store/qxirs94xmghcfsspqg0kai3pirndw70c-piqi-0.6.13
/nix/store/m52d5zmfl3g73yb4lg9wbw5yprrvhg0b-piqi-ocaml-0.7.5

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: ocamlPackages.piqi, ocamlPackages.piqi-ocaml

Partial log (click to expand)

shrinking /nix/store/lyl3llr8jfzm0mrjlwhd64jz8crdq9hc-piqi-ocaml-0.7.5/lib/ocaml/4.06.1/site-lib/piqirun/piqirun_ext.o
wrong ELF type
/nix/store/8wl4dykwswy42wxj671b6k7vk2ydxg86-binutils-2.30/bin/strip is /nix/store/8wl4dykwswy42wxj671b6k7vk2ydxg86-binutils-2.30/bin/strip
stripping (with command /nix/store/8wl4dykwswy42wxj671b6k7vk2ydxg86-binutils-2.30/bin/strip and flags -S) in /nix/store/lyl3llr8jfzm0mrjlwhd64jz8crdq9hc-piqi-ocaml-0.7.5/lib  /nix/store/lyl3llr8jfzm0mrjlwhd64jz8crdq9hc-piqi-ocaml-0.7.5/bin
patching script interpreter paths in /nix/store/lyl3llr8jfzm0mrjlwhd64jz8crdq9hc-piqi-ocaml-0.7.5
checking for references to /build in /nix/store/lyl3llr8jfzm0mrjlwhd64jz8crdq9hc-piqi-ocaml-0.7.5...
wrong ELF type
wrong ELF type
/nix/store/k135ihf4ddpqsxwkiddn49lakbapynis-piqi-0.6.13
/nix/store/lyl3llr8jfzm0mrjlwhd64jz8crdq9hc-piqi-ocaml-0.7.5

@xeji xeji merged commit 58369d7 into NixOS:master Aug 23, 2018
@vbgl vbgl deleted the ocaml-piqi-safe-string branch August 24, 2018 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: ocaml 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vbgl @xeji @GrahamcOfBorg