Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

alibuild: init at 1.5.3 #45467

Merged
merged 1 commit into from Aug 28, 2018
Merged

alibuild: init at 1.5.3 #45467

merged 1 commit into from Aug 28, 2018

Conversation

ktf
Copy link
Contributor

@ktf ktf commented Aug 22, 2018

Motivation for this change

Add new package

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

ryantm
ryantm requested changes Aug 24, 2018
View reviewed changes
Copy link
Member

@ryantm ryantm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of merging master into your branch, please rebase or add your commits on top of master.

pkgs/development/tools/build-managers/alibuild/default.nix Outdated
@@ -0,0 +1,31 @@
{ stdenv, lib, python}:

python.pkgs.buildPythonPackage rec {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is a standalone python application you should use buildPythonApplication.

pkgs/development/tools/build-managers/alibuild/default.nix Outdated
];

patches = [
./fix-argparse.patch
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this patch is not a nix-specific problem, please report to upstream and add a comment linking to the report.

@ktf
Copy link
Contributor Author

ktf commented Aug 24, 2018

I think I've addressed all the comments.

@Mic92 Mic92 merged commit ff9a229 into NixOS:master Aug 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryantm ryantm ryantm requested changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ktf @ryantm @Mic92 @GrahamcOfBorg