Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

webtorrent-desktop: fix .desktop Path entries #45477

Merged
merged 1 commit into from Aug 22, 2018
Merged

webtorrent-desktop: fix .desktop Path entries #45477

merged 1 commit into from Aug 22, 2018

Conversation

KiaraGrouwstra
Copy link
Contributor

Motivation for this change

Fixes the Path=/opt/webtorrent-desktop entries here -- presently these prevent users from launching the application using the .desktop entry.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@KiaraGrouwstra
webtorrent-desktop: fix .desktop Path entries
50812a3 
Fixes the `Path=/opt/webtorrent-desktop` entries [here](https://github.com/webtorrent/webtorrent-desktop/blob/41511c56153b878b0dd39b2adac9525fb66fb35c/static/linux/share/applications/webtorrent-desktop.desktop#L11-L13) -- presently these prevent users from launching the application using the `.desktop` entry.
@KiaraGrouwstra KiaraGrouwstra mentioned this pull request Aug 22, 2018
Closed
@xeji
Copy link
Contributor

xeji commented Aug 22, 2018

@GrahamcOfBorg build webtorrent_desktop

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: webtorrent_desktop

Partial log (click to expand)

copying path '/nix/store/lnjjqbwz9yx609x8dv3mvrdv5yihpcj0-libIDL-0.8.14' from 'https://nix-cache.s3.amazonaws.com'...
copying path '/nix/store/a66vx0d8p02zbr1r32q84ih8pzcg7api-polkit-0.115' from 'https://nix-cache.s3.amazonaws.com'...
copying path '/nix/store/fwyir17nr2pssw7v4wjvddly2z5g9ijx-ORBit2-2.14.19' from 'https://nix-cache.s3.amazonaws.com'...
copying path '/nix/store/garm3gkxmlz2i13kmmfffs6g6rjsxdnd-scrnsaverproto-1.2.2' from 'https://nix-cache.s3.amazonaws.com'...
copying path '/nix/store/igq9r99p4qr003ikk6vyxaqgbhy25r1x-gconf-3.2.6' from 'https://nix-cache.s3.amazonaws.com'...
copying path '/nix/store/ga8x3ihll7al6qkzidlh4cngjih2rz0q-libXScrnSaver-1.2.2' from 'https://nix-cache.s3.amazonaws.com'...
building '/nix/store/99205zf0vbkrpc0dkv9s2lrqlqf3hjk7-webtorrent-desktop-0.20.0.drv'...
unpacking sources
installing
/nix/store/4613ycknbi15ii3d9yh3ab77lw7ah1nw-webtorrent-desktop-0.20.0

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: webtorrent_desktop

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@xeji
Copy link
Contributor

xeji commented Aug 22, 2018

Thank you. I verified this fixes the issue.

@xeji xeji merged commit a89492b into NixOS:master Aug 22, 2018
@KiaraGrouwstra KiaraGrouwstra deleted the webtorrent-desktop-fix-path branch August 22, 2018 21:43
@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: webtorrent_desktop

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@KiaraGrouwstra @xeji @GrahamcOfBorg