Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

boost168: init #45468

Merged
merged 1 commit into from Aug 22, 2018
Merged

boost168: init #45468

merged 1 commit into from Aug 22, 2018

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Aug 22, 2018

Drop patch from 1.67 that's already included.

This only makes it available, default is not changed.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@dtzWill
boost168: init
1f723ab 
Drop patch from 1.67 that's already included.
@xeji
Copy link
Contributor

xeji commented Aug 22, 2018

A bit off-topic: we currently have 9 boost versions in nixpkgs, this will be the 10th!
We should really start dumping old versions...

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: boost168

Partial log (click to expand)

shrinking /nix/store/rlpc667j47am71fg6sq5sf24pysr42d4-boost-1.68_0/lib/libboost_atomic.so.1.68.0
/nix/store/8wl4dykwswy42wxj671b6k7vk2ydxg86-binutils-2.30/bin/strip is /nix/store/8wl4dykwswy42wxj671b6k7vk2ydxg86-binutils-2.30/bin/strip
stripping (with command /nix/store/8wl4dykwswy42wxj671b6k7vk2ydxg86-binutils-2.30/bin/strip and flags -S) in /nix/store/rlpc667j47am71fg6sq5sf24pysr42d4-boost-1.68_0/lib
patching script interpreter paths in /nix/store/rlpc667j47am71fg6sq5sf24pysr42d4-boost-1.68_0
checking for references to /build in /nix/store/rlpc667j47am71fg6sq5sf24pysr42d4-boost-1.68_0...
shrinking RPATHs of ELF executables and libraries in /nix/store/vi89w468zqqk8mh2qkkcag39lfd81ff3-boost-1.68_0-dev
/nix/store/8wl4dykwswy42wxj671b6k7vk2ydxg86-binutils-2.30/bin/strip is /nix/store/8wl4dykwswy42wxj671b6k7vk2ydxg86-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/vi89w468zqqk8mh2qkkcag39lfd81ff3-boost-1.68_0-dev
checking for references to /build in /nix/store/vi89w468zqqk8mh2qkkcag39lfd81ff3-boost-1.68_0-dev...
/nix/store/rlpc667j47am71fg6sq5sf24pysr42d4-boost-1.68_0

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: boost168

Partial log (click to expand)

shrinking /nix/store/yhfbqid175v9c6qj1rzsnrxkrqj89p8f-boost-1.68_0/lib/libboost_coroutine.so.1.68.0
/nix/store/vp40my263xk32f07788srrgl59rycsna-binutils-2.30/bin/strip is /nix/store/vp40my263xk32f07788srrgl59rycsna-binutils-2.30/bin/strip
stripping (with command /nix/store/vp40my263xk32f07788srrgl59rycsna-binutils-2.30/bin/strip and flags -S) in /nix/store/yhfbqid175v9c6qj1rzsnrxkrqj89p8f-boost-1.68_0/lib
patching script interpreter paths in /nix/store/yhfbqid175v9c6qj1rzsnrxkrqj89p8f-boost-1.68_0
checking for references to /build in /nix/store/yhfbqid175v9c6qj1rzsnrxkrqj89p8f-boost-1.68_0...
shrinking RPATHs of ELF executables and libraries in /nix/store/gbd05wv5divky405jnbvr5ws9y84m89j-boost-1.68_0-dev
/nix/store/vp40my263xk32f07788srrgl59rycsna-binutils-2.30/bin/strip is /nix/store/vp40my263xk32f07788srrgl59rycsna-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/gbd05wv5divky405jnbvr5ws9y84m89j-boost-1.68_0-dev
checking for references to /build in /nix/store/gbd05wv5divky405jnbvr5ws9y84m89j-boost-1.68_0-dev...
/nix/store/yhfbqid175v9c6qj1rzsnrxkrqj89p8f-boost-1.68_0

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: boost168

Partial log (click to expand)

/nix/store/8szadm3dmapicciwbvjyxfnyxn9aqb0a-boost-1.68_0/lib/libboost_math_tr1.dylib: fixing dylib
/nix/store/8szadm3dmapicciwbvjyxfnyxn9aqb0a-boost-1.68_0/lib/libboost_atomic.dylib: fixing dylib
/nix/store/8szadm3dmapicciwbvjyxfnyxn9aqb0a-boost-1.68_0/lib/libboost_date_time.dylib: fixing dylib
/nix/store/8szadm3dmapicciwbvjyxfnyxn9aqb0a-boost-1.68_0/lib/libboost_system.dylib: fixing dylib
/nix/store/8szadm3dmapicciwbvjyxfnyxn9aqb0a-boost-1.68_0/lib/libboost_math_c99.dylib: fixing dylib
/nix/store/8szadm3dmapicciwbvjyxfnyxn9aqb0a-boost-1.68_0/lib/libboost_chrono.dylib: fixing dylib
/nix/store/8szadm3dmapicciwbvjyxfnyxn9aqb0a-boost-1.68_0/lib/libboost_context.dylib: fixing dylib
/nix/store/5im29qx9rni3w8l3j8i2yr22sin55kxv-cctools-binutils-darwin/bin/strip is /nix/store/5im29qx9rni3w8l3j8i2yr22sin55kxv-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/lzhsdah4gjqn0ikj6xqzff077zfva2fa-boost-1.68_0-dev
/nix/store/8szadm3dmapicciwbvjyxfnyxn9aqb0a-boost-1.68_0

@bhipple
Copy link
Contributor

bhipple commented Aug 22, 2018

LGTM

@xeji xeji merged commit 162e28f into NixOS:master Aug 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dtzWill @xeji @GrahamcOfBorg @bhipple