Update docs to describe how s3:// URLS does in fact support endpoint, region, and profile for upload #2456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manveru
reviewed
Sep 27, 2018
grahamc
force-pushed
the
s3-substituters
branch
from
86f7f69
to
388bef5
Compare
… region, and profile for upload
grahamc
force-pushed
the
s3-substituters
branch
from
388bef5
to
51cbeec
Compare
|
Also, this one should definitely be backported :) |
edolstra
reviewed
Sep 28, 2018
| "Sid": "AlowDirectReads", | ||
| "Action": [ | ||
| "s3:GetObject", | ||
| "s3:GetBucketLocation" |
There was a problem hiding this comment.
GetBucketLocation is no longer needed.
edolstra
reviewed
Sep 28, 2018
| <example><title>Uploading with non-default credential profile for Amazon S3</title> | ||
| <para><command>nix copy --to ssh://machine nixpkgs.hello s3://example-bucket?profile=cache-upload</command></para> | ||
| <para>Your account will need the following IAM policy to | ||
| upload to the cache:</para> |
There was a problem hiding this comment.
It's a bit strong to say that it needs this IAM policy. Rather the user needs certain rights which may be accomplished via this policy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improvements to #2319 after realizing I was wrong. cc @copumpkin
I've tested all these with AWS S3 (copy-pasted these exact policies) and also DigitalOcean Spaces.
Rendered: https://screenshotscdn.firefoxusercontent.com/images/aa56ce00-b8a9-4616-b701-8ff50c0fc651.png