renoise: add mpg123 to runtime deps #47435
Conversation
GrahamcOfBorg
added
10.rebuild-darwin: 0
|
@the-kenny for review? |
| @@ -35,7 +35,7 @@ stdenv.mkDerivation rec { | |||
| releasePath | |||
| else throw "Platform is not supported by Renoise"; | |||
|
|
|||
| buildInputs = [ libX11 libXext libXcursor libXrandr alsaLib libjack2 ]; | |||
| buildInputs = [ libX11 libXext libXcursor libXrandr alsaLib libjack2 mpg123 ]; | |||
There was a problem hiding this comment.
There is makeWrapper that can be used to put mpg123 into the PATH of renoise.
There was a problem hiding this comment.
Hmm, true, I didn't think about it. I'll modify this PR
jpotier
requested review from
basvandijk,
edwtjo,
FRidh,
peti,
ryantm and
rycee
as code owners
GrahamcOfBorg
added
6.topic: emacs
|
Sorry for the noise… PR is now using |
GrahamcOfBorg
removed
6.topic: emacs
| @@ -56,11 +58,12 @@ stdenv.mkDerivation rec { | |||
| ln -s $out/renoise $out/bin/renoise | |||
|
|
|||
| patchelf --set-interpreter $(cat $NIX_CC/nix-support/dynamic-linker) --set-rpath $out/lib $out/renoise | |||
There was a problem hiding this comment.
I thought it uses the binary from mpg123. If it uses a library from that package, it is better to extend the patchelf command above:
patchelf \
--set-interpreter $(cat $NIX_CC/nix-support/dynamic-linker) \
--set-rpath $out/lib:${mpg123}/lib \
$out/renoise
There was a problem hiding this comment.
True. I checked on their forum and it does need libmpg123.so only.
I tested locally and setting the RPATH to include ${mpg123}/lib does the trick
(app still shows File-IO: Enabling MP3 decoding support using system mpg123 library... in its startup logs)
I'll correct this.
Motivation for this change
Renoise cannot read/use MP3 samples unless mpg123 is available to it.
It's an optional dependency and maybe there's a better way to provide this.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)