Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

haskellPackages.generic-lens: dontCheck #47424

Merged
merged 1 commit into from Sep 28, 2018
Merged

haskellPackages.generic-lens: dontCheck #47424

merged 1 commit into from Sep 28, 2018

Conversation

Taneb
Copy link
Contributor

@Taneb Taneb commented Sep 27, 2018

Motivation for this change

The test suite for generic-lens currently fails to build.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@basvandijk
Copy link
Member

@GrahamcOfBorg build haskellPackages.generic-lens

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: haskellPackages.generic-lens

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: haskellPackages.generic-lens

Partial log (click to expand)

Preprocessing test suite 'generic-lens-test' for generic-lens-1.0.0.2..
installing
Installing library in /nix/store/a2p1j28r0jmgs5xjcc1q4cnchbjwg97w-generic-lens-1.0.0.2/lib/ghc-8.4.3/x86_64-osx-ghc-8.4.3/generic-lens-1.0.0.2-2RHbhJokaSsFvWPnf3PoSt
post-installation fixup
strip is /nix/store/4w56qihlrddav67p7d1vy5qkyayaqw11-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/a2p1j28r0jmgs5xjcc1q4cnchbjwg97w-generic-lens-1.0.0.2/lib
patching script interpreter paths in /nix/store/a2p1j28r0jmgs5xjcc1q4cnchbjwg97w-generic-lens-1.0.0.2
strip is /nix/store/4w56qihlrddav67p7d1vy5qkyayaqw11-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/v6mydw76kd6s0mjy0i2ljnclld2aph81-generic-lens-1.0.0.2-doc
/nix/store/a2p1j28r0jmgs5xjcc1q4cnchbjwg97w-generic-lens-1.0.0.2

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: haskellPackages.generic-lens

Partial log (click to expand)

strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/bh6ikpc2v1yqxgxz8ajwrsys5vlpdw42-generic-lens-1.0.0.2/lib
patching script interpreter paths in /nix/store/bh6ikpc2v1yqxgxz8ajwrsys5vlpdw42-generic-lens-1.0.0.2
checking for references to /build in /nix/store/bh6ikpc2v1yqxgxz8ajwrsys5vlpdw42-generic-lens-1.0.0.2...
wrong ELF type
shrinking RPATHs of ELF executables and libraries in /nix/store/i5iksfmhdjk069b3g660bbqipjjb7328-generic-lens-1.0.0.2-doc
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/i5iksfmhdjk069b3g660bbqipjjb7328-generic-lens-1.0.0.2-doc
checking for references to /build in /nix/store/i5iksfmhdjk069b3g660bbqipjjb7328-generic-lens-1.0.0.2-doc...
/nix/store/bh6ikpc2v1yqxgxz8ajwrsys5vlpdw42-generic-lens-1.0.0.2

@basvandijk basvandijk merged commit 0ab8fa2 into NixOS:master Sep 28, 2018
@basvandijk
Copy link
Member

Thanks @Taneb!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@basvandijk basvandijk basvandijk approved these changes

@peti peti Awaiting requested review from peti

@ryantm ryantm Awaiting requested review from ryantm

Assignees
No one assigned
Labels
6.topic: haskell 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Taneb @basvandijk @GrahamcOfBorg