Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

arc-theme: fix config.allowAliases = false evaluation #47427

Merged
merged 1 commit into from Sep 27, 2018
Merged

arc-theme: fix config.allowAliases = false evaluation #47427

merged 1 commit into from Sep 27, 2018

Conversation

dywedir
Copy link
Member

@dywedir dywedir commented Sep 27, 2018

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: arc-theme

Partial log (click to expand)

these paths will be fetched (2.53 MiB download, 9.80 MiB unpacked):
  /nix/store/b8svz8gnl07hvnppch6xd188mypnc00w-arc-theme-20180715
  /nix/store/r64g3v76ki8nr79i4mffm4fdg5cv95kz-gnome-themes-extra-3.28
  /nix/store/w7jd8kzn6n612xw4vc2j62h7lp2a882m-gtk-engine-murrine-0.98.2
copying path '/nix/store/r64g3v76ki8nr79i4mffm4fdg5cv95kz-gnome-themes-extra-3.28' from 'https://cache.nixos.org'...
copying path '/nix/store/w7jd8kzn6n612xw4vc2j62h7lp2a882m-gtk-engine-murrine-0.98.2' from 'https://cache.nixos.org'...
copying path '/nix/store/b8svz8gnl07hvnppch6xd188mypnc00w-arc-theme-20180715' from 'https://cache.nixos.org'...
/nix/store/b8svz8gnl07hvnppch6xd188mypnc00w-arc-theme-20180715

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: arc-theme

Partial log (click to expand)

these paths will be fetched (2.54 MiB download, 9.87 MiB unpacked):
  /nix/store/5485lcpgc18si0hgrhq5wq3z4hgzbj6n-arc-theme-20180715
  /nix/store/9lg55g0pq9zsnk9gm7306dh6inqpzblk-gnome-themes-extra-3.28
  /nix/store/l7m0l22byv5hc3hi42wsvlgy8kwl0p13-gtk-engine-murrine-0.98.2
copying path '/nix/store/9lg55g0pq9zsnk9gm7306dh6inqpzblk-gnome-themes-extra-3.28' from 'https://cache.nixos.org'...
copying path '/nix/store/l7m0l22byv5hc3hi42wsvlgy8kwl0p13-gtk-engine-murrine-0.98.2' from 'https://cache.nixos.org'...
copying path '/nix/store/5485lcpgc18si0hgrhq5wq3z4hgzbj6n-arc-theme-20180715' from 'https://cache.nixos.org'...
/nix/store/5485lcpgc18si0hgrhq5wq3z4hgzbj6n-arc-theme-20180715

@xeji
Copy link
Contributor

xeji commented Sep 27, 2018

Thank you for catching this!
(I hate that alias stuff ...)

@xeji xeji merged commit 312c41c into NixOS:master Sep 27, 2018
@dywedir dywedir deleted the arc-theme branch September 27, 2018 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dywedir @GrahamcOfBorg @xeji