nbd: add which to buildInputs #46635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mic92
reviewed
Sep 14, 2018
| @@ -11,7 +11,7 @@ stdenv.mkDerivation rec { | |||
| patches = [ ./dont-run-make-in-broken-systemd-subdir.patch ]; | |||
|
|
|||
| buildInputs = | |||
| [ pkgconfig glib ] | |||
| [ pkgconfig glib which ] | |||
There was a problem hiding this comment.
Can you add this to nativeBuildInputs instead? Also pkgconfig belongs there.
There was a problem hiding this comment.
Gah! One day, I'll get something right the first time.
There was a problem hiding this comment.
You can also cargo-cult this knowledge for examples like pkgconfig.
A rule of thumb is: Does the system (i.e x86_64) that builds the packages would like to execute this tool during its build and therefore needs the executable for its own cpu architecture or is it a dependencies that is needed for the target platform (aarch64), that the package is build for.
|
@GrahamcOfBorg build nbd |
|
No attempt on x86_64-darwin (full log) The following builds were skipped because they don't evaluate on x86_64-darwin: nbd Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: nbd Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: nbd Partial log (click to expand)
|
qolii
force-pushed
the
nbd_add_which_2
branch
from
fd2650d
to
9dc4ab0
Compare
qolii
force-pushed
the
nbd_add_which_2
branch
from
9dc4ab0
to
36bca31
Compare
|
(No idea what happened with the conflict there. I've rebased, looks ok now.) |
|
@GrahamcOfBorg build nbd |
|
sorry, not everyone can trigger builds |
|
No attempt on x86_64-darwin (full log) The following builds were skipped because they don't evaluate on x86_64-darwin: nbd Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: nbd Partial log (click to expand)
|
|
Ah, hehe. Thought I'd give the magic incantation a try :) |
|
Success on aarch64-linux (full log) Attempted: nbd Partial log (click to expand)
|
|
Thanks @xeji! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
The
nbdbuild complains numerously about not being able to find thewhichpackage during its testing phase:and so on.
I'm not sure why the build doesn't fail under these conditions, but anyway, simply adding
whichto itsbuildInputsfixes this.Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)