Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xpra: port to gtk3 #46613

Merged
merged 2 commits into from Oct 18, 2018
Merged

xpra: port to gtk3 #46613

merged 2 commits into from Oct 18, 2018

Conversation

jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Sep 13, 2018 •
edited

Motivation for this change

Removing old cruft

cc @atanasi @7c6f434c @calvertvl @offlinehacker @bjornfor

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: xpra

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: xpra

Partial log (click to expand)

/nix/store/46mys3w4shwq4qak68hm1xajgvan5f0s-xpra-2.3.3/lib/xpra/gvfs-open: interpreter directive changed from "/bin/sh" to "/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/sh"
/nix/store/46mys3w4shwq4qak68hm1xajgvan5f0s-xpra-2.3.3/lib/xpra/auth_dialog: interpreter directive changed from "/usr/bin/env python" to "/nix/store/hy65mn4wjswqih75gfr6g4q3xgqdm325-python3-3.6.6/bin/python"
/nix/store/46mys3w4shwq4qak68hm1xajgvan5f0s-xpra-2.3.3/lib/xpra/gnome-open: interpreter directive changed from "/bin/sh" to "/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/sh"
/nix/store/46mys3w4shwq4qak68hm1xajgvan5f0s-xpra-2.3.3/lib/xpra/xdg-open: interpreter directive changed from "/usr/bin/env python" to "/nix/store/hy65mn4wjswqih75gfr6g4q3xgqdm325-python3-3.6.6/bin/python"
/nix/store/46mys3w4shwq4qak68hm1xajgvan5f0s-xpra-2.3.3/lib/cups/backend/xpraforwarder: interpreter directive changed from "/usr/bin/env python" to "/nix/store/hy65mn4wjswqih75gfr6g4q3xgqdm325-python3-3.6.6/bin/python"
checking for references to /build in /nix/store/46mys3w4shwq4qak68hm1xajgvan5f0s-xpra-2.3.3...
wrapping `/nix/store/46mys3w4shwq4qak68hm1xajgvan5f0s-xpra-2.3.3/bin/.xpra_browser-wrapped'...
wrapping `/nix/store/46mys3w4shwq4qak68hm1xajgvan5f0s-xpra-2.3.3/bin/.xpra_launcher-wrapped'...
wrapping `/nix/store/46mys3w4shwq4qak68hm1xajgvan5f0s-xpra-2.3.3/bin/.xpra-wrapped'...
wrapping `/nix/store/46mys3w4shwq4qak68hm1xajgvan5f0s-xpra-2.3.3/bin/.xpra_signal_listener-wrapped'...

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: xpra

Partial log (click to expand)

/nix/store/618lmcmw8n752gg6ypm5ixr5gakzbkcm-xpra-2.3.3/lib/xpra/auth_dialog: interpreter directive changed from "/usr/bin/env python" to "/nix/store/sb88r9crdhinhkm6vpxwzf5zmij86p8v-python3-3.6.6/bin/python"
/nix/store/618lmcmw8n752gg6ypm5ixr5gakzbkcm-xpra-2.3.3/lib/xpra/gnome-open: interpreter directive changed from "/bin/sh" to "/nix/store/fqm2x6kiay1q4vg7pqp4wp17bdijlyc3-bash-4.4-p23/bin/sh"
/nix/store/618lmcmw8n752gg6ypm5ixr5gakzbkcm-xpra-2.3.3/lib/xpra/gvfs-open: interpreter directive changed from "/bin/sh" to "/nix/store/fqm2x6kiay1q4vg7pqp4wp17bdijlyc3-bash-4.4-p23/bin/sh"
/nix/store/618lmcmw8n752gg6ypm5ixr5gakzbkcm-xpra-2.3.3/lib/xpra/xdg-open: interpreter directive changed from "/usr/bin/env python" to "/nix/store/sb88r9crdhinhkm6vpxwzf5zmij86p8v-python3-3.6.6/bin/python"
checking for references to /build in /nix/store/618lmcmw8n752gg6ypm5ixr5gakzbkcm-xpra-2.3.3...
wrapping `/nix/store/618lmcmw8n752gg6ypm5ixr5gakzbkcm-xpra-2.3.3/bin/.xpra_signal_listener-wrapped'...
wrapping `/nix/store/618lmcmw8n752gg6ypm5ixr5gakzbkcm-xpra-2.3.3/bin/.xpra_launcher-wrapped'...
wrapping `/nix/store/618lmcmw8n752gg6ypm5ixr5gakzbkcm-xpra-2.3.3/bin/.xpra_browser-wrapped'...
wrapping `/nix/store/618lmcmw8n752gg6ypm5ixr5gakzbkcm-xpra-2.3.3/bin/.xpra-wrapped'...
/nix/store/618lmcmw8n752gg6ypm5ixr5gakzbkcm-xpra-2.3.3

@jtojnar
xpra: modernize
3b685ee 
Port to Python 3 and GTK+ 3.
@jtojnar
xpraGtk3: point to xpra
d4d87b0 
xpra now uses GTK 3
@jtojnar
Copy link
Contributor Author

jtojnar commented Oct 4, 2018

@numinit could you please take a look at this?

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: xpra

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: xpra

Partial log (click to expand)

/nix/store/alqrdb1cd80f8n1g0fw8h31zqrdgai4n-xpra-2.3.3/lib/xpra/gvfs-open: interpreter directive changed from "/bin/sh" to "/nix/store/nii7pk6pv4x4as7vsxbvwyzjn67vax6r-bash-4.4-p23/bin/sh"
/nix/store/alqrdb1cd80f8n1g0fw8h31zqrdgai4n-xpra-2.3.3/lib/xpra/auth_dialog: interpreter directive changed from "/usr/bin/env python" to "/nix/store/1c4zshbxizcsvyj46fwf5jj10h41wf6i-python3-3.6.6/bin/python"
/nix/store/alqrdb1cd80f8n1g0fw8h31zqrdgai4n-xpra-2.3.3/lib/xpra/gnome-open: interpreter directive changed from "/bin/sh" to "/nix/store/nii7pk6pv4x4as7vsxbvwyzjn67vax6r-bash-4.4-p23/bin/sh"
/nix/store/alqrdb1cd80f8n1g0fw8h31zqrdgai4n-xpra-2.3.3/lib/xpra/xdg-open: interpreter directive changed from "/usr/bin/env python" to "/nix/store/1c4zshbxizcsvyj46fwf5jj10h41wf6i-python3-3.6.6/bin/python"
/nix/store/alqrdb1cd80f8n1g0fw8h31zqrdgai4n-xpra-2.3.3/lib/cups/backend/xpraforwarder: interpreter directive changed from "/usr/bin/env python" to "/nix/store/1c4zshbxizcsvyj46fwf5jj10h41wf6i-python3-3.6.6/bin/python"
checking for references to /build in /nix/store/alqrdb1cd80f8n1g0fw8h31zqrdgai4n-xpra-2.3.3...
wrapping `/nix/store/alqrdb1cd80f8n1g0fw8h31zqrdgai4n-xpra-2.3.3/bin/.xpra_browser-wrapped'...
wrapping `/nix/store/alqrdb1cd80f8n1g0fw8h31zqrdgai4n-xpra-2.3.3/bin/.xpra_launcher-wrapped'...
wrapping `/nix/store/alqrdb1cd80f8n1g0fw8h31zqrdgai4n-xpra-2.3.3/bin/.xpra-wrapped'...
wrapping `/nix/store/alqrdb1cd80f8n1g0fw8h31zqrdgai4n-xpra-2.3.3/bin/.xpra_signal_listener-wrapped'...

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: xpra

Partial log (click to expand)

/nix/store/6qlc05487h045wzkq90y93s0lyd2zv2h-xpra-2.3.3/lib/xpra/auth_dialog: interpreter directive changed from "/usr/bin/env python" to "/nix/store/0cymph4p1781g26ihhldnz74wzi0m2y0-python3-3.6.6/bin/python"
/nix/store/6qlc05487h045wzkq90y93s0lyd2zv2h-xpra-2.3.3/lib/xpra/gnome-open: interpreter directive changed from "/bin/sh" to "/nix/store/017xymp5i03qzigafnfx7sgf6602gmzq-bash-4.4-p23/bin/sh"
/nix/store/6qlc05487h045wzkq90y93s0lyd2zv2h-xpra-2.3.3/lib/xpra/gvfs-open: interpreter directive changed from "/bin/sh" to "/nix/store/017xymp5i03qzigafnfx7sgf6602gmzq-bash-4.4-p23/bin/sh"
/nix/store/6qlc05487h045wzkq90y93s0lyd2zv2h-xpra-2.3.3/lib/xpra/xdg-open: interpreter directive changed from "/usr/bin/env python" to "/nix/store/0cymph4p1781g26ihhldnz74wzi0m2y0-python3-3.6.6/bin/python"
checking for references to /build in /nix/store/6qlc05487h045wzkq90y93s0lyd2zv2h-xpra-2.3.3...
wrapping `/nix/store/6qlc05487h045wzkq90y93s0lyd2zv2h-xpra-2.3.3/bin/.xpra_signal_listener-wrapped'...
wrapping `/nix/store/6qlc05487h045wzkq90y93s0lyd2zv2h-xpra-2.3.3/bin/.xpra_launcher-wrapped'...
wrapping `/nix/store/6qlc05487h045wzkq90y93s0lyd2zv2h-xpra-2.3.3/bin/.xpra_browser-wrapped'...
wrapping `/nix/store/6qlc05487h045wzkq90y93s0lyd2zv2h-xpra-2.3.3/bin/.xpra-wrapped'...
/nix/store/6qlc05487h045wzkq90y93s0lyd2zv2h-xpra-2.3.3

@jtojnar jtojnar merged commit 21f20b5 into NixOS:master Oct 18, 2018
@jtojnar jtojnar deleted the xpra-gtk3 branch October 18, 2018 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jtojnar @GrahamcOfBorg