Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

papi: init at 5.6.0 #46619

Merged
merged 1 commit into from Sep 13, 2018
Merged

papi: init at 5.6.0 #46619

merged 1 commit into from Sep 13, 2018

Conversation

costrouc
Copy link
Member

papi is a high resolution performance counter.

Motivation for this change

wanted to add a library I use for evaluating software performance.

Things done

papi: init at 5.6.0

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

xeji
xeji reviewed Sep 13, 2018
View reviewed changes
pkgs/development/libraries/science/benchmark/papi/default.nix Outdated
homepage = https://icl.utk.edu/papi/;
description = "PAPI provides the tool designer and application engineer with a consistent interface and methodology for use of the performance counter hardware found in most major microprocessors";
license = licenses.bsdOriginal;
maintainers = [ maintainers.costrouc ];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add meta.platforms.

@costrouc costrouc force-pushed the costrouc/papi-init branch 2 times, most recently from 32a54ff to 790f3b2 Compare September 13, 2018 18:19
@costrouc
Copy link
Member Author

platforms.all has been added and in current pull request.

@xeji
Copy link
Contributor

xeji commented Sep 13, 2018

Thank you. Let's see if it really builds on all our platforms.
@GrahamcOfBorg build papi

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: papi

Partial log (click to expand)

clang -I../testlib -I.. -I. -DNEED_FFSLL -O2  -c display_error.c
clang -I../testlib -I.. -I. -DNEED_FFSLL -O2  -c instructions_testcode.c
clang -o cycles_validation cycles_validation.o ../testlib/libtestlib.a display_error.o instructions_testcode.o ../libpapi.a  -lrt
ld: library not found for -lrt
clang-5.0: error: linker command failed with exit code 1 (use -v to see invocation)
make[1]: *** [Makefile.recipies:43: cycles_validation] Error 1
make[1]: Leaving directory '/private/tmp/nix-build-papi-5.6.0.drv-0/icl-papi-31d2ae8200ba/src/validation_tests'
make: *** [Makefile.inc:237: validation_tests] Error 2
builder for '/nix/store/sf5pksvfa18cgpizbjilm6krkx1p00yz-papi-5.6.0.drv' failed with exit code 2
error: build of '/nix/store/sf5pksvfa18cgpizbjilm6krkx1p00yz-papi-5.6.0.drv' failed

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: papi

Partial log (click to expand)

shrinking /nix/store/4g78xv4hhcszxfikyis6xwy79pq4g26y-papi-5.6.0/bin/papi_clockres
shrinking /nix/store/4g78xv4hhcszxfikyis6xwy79pq4g26y-papi-5.6.0/bin/papi_event_chooser
shrinking /nix/store/4g78xv4hhcszxfikyis6xwy79pq4g26y-papi-5.6.0/lib/libpfm.so.4.8.0
shrinking /nix/store/4g78xv4hhcszxfikyis6xwy79pq4g26y-papi-5.6.0/lib/libpapi.so.5.6.0.0
gzipping man pages under /nix/store/4g78xv4hhcszxfikyis6xwy79pq4g26y-papi-5.6.0/share/man/
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/4g78xv4hhcszxfikyis6xwy79pq4g26y-papi-5.6.0/lib  /nix/store/4g78xv4hhcszxfikyis6xwy79pq4g26y-papi-5.6.0/bin
patching script interpreter paths in /nix/store/4g78xv4hhcszxfikyis6xwy79pq4g26y-papi-5.6.0
checking for references to /build in /nix/store/4g78xv4hhcszxfikyis6xwy79pq4g26y-papi-5.6.0...
/nix/store/4g78xv4hhcszxfikyis6xwy79pq4g26y-papi-5.6.0

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: papi

Partial log (click to expand)

shrinking /nix/store/hxplylzp4bc8577g6pajlb6fy4y1siy6-papi-5.6.0/bin/papi_component_avail
shrinking /nix/store/hxplylzp4bc8577g6pajlb6fy4y1siy6-papi-5.6.0/bin/papi_error_codes
shrinking /nix/store/hxplylzp4bc8577g6pajlb6fy4y1siy6-papi-5.6.0/lib/libpapi.so.5.6.0.0
shrinking /nix/store/hxplylzp4bc8577g6pajlb6fy4y1siy6-papi-5.6.0/lib/libpfm.so.4.8.0
gzipping man pages under /nix/store/hxplylzp4bc8577g6pajlb6fy4y1siy6-papi-5.6.0/share/man/
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/hxplylzp4bc8577g6pajlb6fy4y1siy6-papi-5.6.0/lib  /nix/store/hxplylzp4bc8577g6pajlb6fy4y1siy6-papi-5.6.0/bin
patching script interpreter paths in /nix/store/hxplylzp4bc8577g6pajlb6fy4y1siy6-papi-5.6.0
checking for references to /build in /nix/store/hxplylzp4bc8577g6pajlb6fy4y1siy6-papi-5.6.0...
/nix/store/hxplylzp4bc8577g6pajlb6fy4y1siy6-papi-5.6.0

@costrouc
Copy link
Member Author

looks like it failed on darwin running the tests. Failed with ld: library not found for -lrt.

Looking at the mailing list. They do support BSD but OSX was not intentionally supported and doesn't fully work https://lists.eecs.utk.edu/pipermail/perfapi-devel/2015-February/006879.html

I will remove darwin support

@xeji
Copy link
Contributor

xeji commented Sep 13, 2018

platforms = platforms.linux; fits best here.

@costrouc
papi: init at 5.6.0
41eddb5 
papi is a high resolution performance counter.
@costrouc
Copy link
Member Author

platforms has been set to platforms.linux. Thanks for the advice.

@xeji
Copy link
Contributor

xeji commented Sep 13, 2018

@GrahamcOfBorg build papi

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: papi

Partial log (click to expand)

/nix/store/hxplylzp4bc8577g6pajlb6fy4y1siy6-papi-5.6.0

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: papi

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: papi

Partial log (click to expand)

shrinking /nix/store/4g78xv4hhcszxfikyis6xwy79pq4g26y-papi-5.6.0/bin/papi_command_line
shrinking /nix/store/4g78xv4hhcszxfikyis6xwy79pq4g26y-papi-5.6.0/bin/papi_event_chooser
shrinking /nix/store/4g78xv4hhcszxfikyis6xwy79pq4g26y-papi-5.6.0/bin/papi_clockres
shrinking /nix/store/4g78xv4hhcszxfikyis6xwy79pq4g26y-papi-5.6.0/bin/papi_multiplex_cost
gzipping man pages under /nix/store/4g78xv4hhcszxfikyis6xwy79pq4g26y-papi-5.6.0/share/man/
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/4g78xv4hhcszxfikyis6xwy79pq4g26y-papi-5.6.0/lib  /nix/store/4g78xv4hhcszxfikyis6xwy79pq4g26y-papi-5.6.0/bin
patching script interpreter paths in /nix/store/4g78xv4hhcszxfikyis6xwy79pq4g26y-papi-5.6.0
checking for references to /build in /nix/store/4g78xv4hhcszxfikyis6xwy79pq4g26y-papi-5.6.0...
/nix/store/4g78xv4hhcszxfikyis6xwy79pq4g26y-papi-5.6.0

@xeji xeji merged commit 9ef31b2 into NixOS:master Sep 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xeji xeji xeji left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@costrouc @xeji @GrahamcOfBorg